From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#35476: font-lock-{append, prepend}-text-property and anonymous faces Date: Mon, 13 May 2019 21:01:33 -0400 Message-ID: <87v9ydg87m.fsf@gmail.com> References: <87lfzu9hsl.fsf@gmail.com> <87a7g8owim.fsf@gmail.com> <87ftpqq1kl.fsf_-_@gmail.com> <87a7frj1qg.fsf_-_@gmail.com> <87d0knshkm.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="180756"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: 35476@debbugs.gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 14 05:54:33 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQOWO-000ku5-53 for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 May 2019 05:54:32 +0200 Original-Received: from localhost ([127.0.0.1]:38582 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQOWN-0001PE-7H for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 May 2019 23:54:31 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57035) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQOUq-0000Ro-Ma for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 23:52:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQOUo-0003f5-GN for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 23:52:56 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33116) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQLpS-0008IH-QD for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 21:02:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hQLpS-0000As-HX for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 21:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 May 2019 01:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35476 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35476-submit@debbugs.gnu.org id=B35476.1557795706643 (code B ref 35476); Tue, 14 May 2019 01:02:02 +0000 Original-Received: (at 35476) by debbugs.gnu.org; 14 May 2019 01:01:46 +0000 Original-Received: from localhost ([127.0.0.1]:46658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQLpC-0000AI-G8 for submit@debbugs.gnu.org; Mon, 13 May 2019 21:01:46 -0400 Original-Received: from mail-io1-f44.google.com ([209.85.166.44]:38188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQLp7-00009n-AE; Mon, 13 May 2019 21:01:41 -0400 Original-Received: by mail-io1-f44.google.com with SMTP id x24so4208774ion.5; Mon, 13 May 2019 18:01:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=Ss+16aKfmjKAp3yMw0M0zJo07MRe2mraZKZyVS4MO20=; b=f/87kGGJkUOoQHZ4dYfz74+D7WetJceDUKkoT4EWCL2fpU22c5rcjgkvRWEs1FFlda 84wVExDuFQBayq855vHa5+RvSQE6Q1MUixv60LVNZ57eI/4nsYU8cyaZAlpj+tJTSZHR +7WNSwazYSrQspDCHQ5X6T79wofTeqfLSEDL824NwjzL/bEZjSIdEh01rHbzoRMG3FkY ve1OvfCeqbbrTVoINDaIFvpddIJX95nHH87UlgbzewXuM4puc2BMqp2wJAOrZ0y0bmzg jg5nRL2zmQ098XKg5oJqD51WLzhkZRvXlJkIk/qWGNS4n9p2e+A99ww564LxYmdhM5JS 6Kfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Ss+16aKfmjKAp3yMw0M0zJo07MRe2mraZKZyVS4MO20=; b=ZQTm/p8PU0s+d1ebHd0T8dC+CN0TcbjPkaOeEijhzYj/XDKi8cno+N5hPg7kpmSuT4 phoQgZjfuoNjAjCAJVe3BY4hEyswR4lzZ/kt0MgbXp2CACXI6LLGoKia6eXGjmKJ11Tp 9MIM5y3MOfGu1SuplNwxuuc8+bWRNuhg4LEXMkXlOYEHX4r5RihlSN/ZtRT875AA7FOB zgNmVZaCAZ3rcA7ij8aUbG77dgZiI0VvWcnNlhefepbzVU1Ro+ijm8dI/zF2SLpfZUPm CVjBWzl88AmiGAvcW3FQAwJLEyaVeFJkV47CeafohBJHHl0SW2T5jevLFQbrsO4A+A/8 iRpA== X-Gm-Message-State: APjAAAXfxcWHfuUe/eZb0qkUoD6ssVxNctH17j46U9YsPssvI2nE2QJQ n5GpAVFU8RJgEqct69sQxZmHzWUz X-Google-Smtp-Source: APXvYqxcf5sF2bah7LV/gQrjkeR1V+uQEqlST/BayGknxZ4aUVHMHMxMbpVnQzT5afkRfsaSy4+pkA== X-Received: by 2002:a6b:8bc8:: with SMTP id n191mr17028622iod.86.1557795695256; Mon, 13 May 2019 18:01:35 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id t63sm591637ita.42.2019.05.13.18.01.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 May 2019 18:01:34 -0700 (PDT) In-Reply-To: <87d0knshkm.fsf@gmail.com> ("=?UTF-8?Q?K=C3=A9vin?= Le Gouguec"'s message of "Sun, 12 May 2019 19:34:01 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159239 Archived-At: tags 35476 fixed close 35476 27.1 quit K=C3=A9vin Le Gouguec writes: > [1] Although running 'make lisp/font-lock-tests' in the test/ folder > fails on the append test. Could it be that the Makefile runs the > tests against the old font-lock.el that is installed on my system, > rather than the new one in my repository? I took a look at the > test_template in test/Makefile, but I could not understand what the > machinery loads at a glance. I forgot to answer this before. There's two issues here: 1. The default value of load-prefer-newer means that of you change a .el file without recompiling it, Emacs will load the .elc file instead. 2. For font-lock.el in particular, it's preloaded, so even if you recompile it, font-lock.elc isn't loaded again, you need to redump Emacs. So generally, the way to test changes is make && make -C test font-lock-tests Although it should also work to load the modified .el file explicitly (untested, but): make -C test EMACS_EXTRAOPT=3D'-l font-lock.el' font-lock-tests >> It's best to avoid using hashes in commit messages, as they're >> translated to ChangeLog files which might read from the tarball (i.e., >> without a git repo to hand). CONTRIBUTE talks about using "action >> stamps" but I think date+title is more readable. Which would be: >> 2019-04-29 "Refrain from splicing anonymous faces in text properties". > > Ah, right, didn't think of the children^WChangeLog. :D =20=20 > Can e.g. git-show(1) understand action stamps? I glanced at > gitrevisions(7) but nothing suggests Git knows anything about this > format. I don't think so. The last time I brought this up on emacs-devel there was some suggestion that cgit (a git web frontend) would learn to recognize them eventually, but I'm not sure if anything is really moving in that direction. > (Or, going the opposite route, maybe the git-log-to-ChangeLog machinery > could translate hashes to action stamps?) Maybe, although personally, as a human reader, I prefer date+title to both hashes and action stamps, even when reading from git. Yes, it's quicker to find a commit given a hash, but that still requires at least pressing RET or clicking or something like that. Quite often, just seeing the title is enough to understand what's meant and I don't need to dig further. > Thank you for the review! Let me know if there are further nits to > pick. I think we're good here, pushed to master. 417c52b0b7 2019-05-13T20:41:02-04:00 "Extract common code for adding text p= roperties" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D417c52b0b7fbf5cb02= d229e81b7aaaacf2082bde 59ad303e8f 2019-05-13T20:41:02-04:00 "Stop splicing anonymous faces in font= -lock-append-text-property" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D59ad303e8f3bb174ce= 326c76a9e7649f602120db