Reverting e51adfbdb7?

Reverting e51adfbdb7?

[Eric Abrahamsen]

I could have sworn I saw some discussion of this here, but now I can't
find it...

Commit e51adfbdb7 makes it impossible for me to send *any* messages via
nntp, not just those with long continuation lines. I've been running
with a local reversion for several days now. Can it either be fixed soonish,
or reverted until a fix is ready?

Thanks,
Eric

Re: Reverting e51adfbdb7?

[Noam Postavsky]

On Thu, 13 Jun 2019 at 19:00, Eric Abrahamsen <eric@ericabrahamsen.net> wrote:
>
> I could have sworn I saw some discussion of this here, but now I can't
> find it...

This one I think? https://lists.gnu.org/r/emacs-devel/2019-06/msg00130.html

Re: Reverting e51adfbdb7?

[Eric Abrahamsen]

Noam Postavsky <npostavs@gmail.com> writes:

> On Thu, 13 Jun 2019 at 19:00, Eric Abrahamsen <eric@ericabrahamsen.net> wrote:
>>
>> I could have sworn I saw some discussion of this here, but now I can't
>> find it...
>
> This one I think? https://lists.gnu.org/r/emacs-devel/2019-06/msg00130.html

Yes! Thank you. I wish search still worked in gmane... I'll follow that thread.

Re: Reverting e51adfbdb7?

[Stefan Monnier]

> Commit e51adfbdb7 makes it impossible for me to send *any* messages via
> nntp, not just those with long continuation lines. I've been running
> with a local reversion for several days now. Can it either be fixed soonish,
> or reverted until a fix is ready?

I'm trying the patch below right now,


        Stefan


diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
index 21c31f3244..86c4dce7d8 100644
--- a/lisp/gnus/message.el
+++ b/lisp/gnus/message.el
@@ -5178,7 +5176,7 @@ message-check-news-header-syntax
 	   (if (= (length errors) 1) "this" "these")
 	   (if (= (length errors) 1) "" "s")
 	   (mapconcat 'identity errors ", ")))))))
-   (message--check-continuation-headers)
+   (progn (message--check-continuation-headers) t)
    ;; Check the Newsgroups & Followup-To headers for syntax errors.
    (message-check 'valid-newsgroups
      (let ((case-fold-search t)

Re: Reverting e51adfbdb7?

[Eric Abrahamsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Commit e51adfbdb7 makes it impossible for me to send *any* messages via
>> nntp, not just those with long continuation lines. I've been running
>> with a local reversion for several days now. Can it either be fixed soonish,
>> or reverted until a fix is ready?
>
> I'm trying the patch below right now,
>
>
>         Stefan
>
>
> diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
> index 21c31f3244..86c4dce7d8 100644
> --- a/lisp/gnus/message.el
> +++ b/lisp/gnus/message.el
> @@ -5178,7 +5176,7 @@ message-check-news-header-syntax
>  	   (if (= (length errors) 1) "this" "these")
>  	   (if (= (length errors) 1) "" "s")
>  	   (mapconcat 'identity errors ", ")))))))
> -   (message--check-continuation-headers)
> +   (progn (message--check-continuation-headers) t)
>     ;; Check the Newsgroups & Followup-To headers for syntax errors.
>     (message-check 'valid-newsgroups
>       (let ((case-fold-search t)

Well that's certainly simpler than the patch I posted to the other
thread! I was trying to keep this clause looking similar to the other
clauses, to minimize mental overhead for the reader, but whatever works...