all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-devel@gnu.org
Subject: Re: Reverting e51adfbdb7?
Date: Fri, 14 Jun 2019 01:14:59 -0700	[thread overview]
Message-ID: <87v9x8eg70.fsf@ericabrahamsen.net> (raw)
In-Reply-To: jwvimt8y8qt.fsf-monnier+emacs@gnu.org

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Commit e51adfbdb7 makes it impossible for me to send *any* messages via
>> nntp, not just those with long continuation lines. I've been running
>> with a local reversion for several days now. Can it either be fixed soonish,
>> or reverted until a fix is ready?
>
> I'm trying the patch below right now,
>
>
>         Stefan
>
>
> diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
> index 21c31f3244..86c4dce7d8 100644
> --- a/lisp/gnus/message.el
> +++ b/lisp/gnus/message.el
> @@ -5178,7 +5176,7 @@ message-check-news-header-syntax
>  	   (if (= (length errors) 1) "this" "these")
>  	   (if (= (length errors) 1) "" "s")
>  	   (mapconcat 'identity errors ", ")))))))
> -   (message--check-continuation-headers)
> +   (progn (message--check-continuation-headers) t)
>     ;; Check the Newsgroups & Followup-To headers for syntax errors.
>     (message-check 'valid-newsgroups
>       (let ((case-fold-search t)

Well that's certainly simpler than the patch I posted to the other
thread! I was trying to keep this clause looking similar to the other
clauses, to minimize mental overhead for the reader, but whatever works...




      reply	other threads:[~2019-06-14  8:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-13 22:47 Reverting e51adfbdb7? Eric Abrahamsen
2019-06-13 23:05 ` Noam Postavsky
2019-06-13 23:10   ` Eric Abrahamsen
2019-06-14  6:39 ` Stefan Monnier
2019-06-14  8:14   ` Eric Abrahamsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9x8eg70.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.