From: Spenser Truex <web@spensertruex.com>
To: emacs-devel@gnu.org
Subject: FIXME: When the reader is called in the minibuffer.
Date: Sat, 29 Jun 2019 22:05:53 -0700 [thread overview]
Message-ID: <87v9wn8xxq.fsf_-_@spensertruex.com> (raw)
In-Reply-To: <CAC45yQtydsv1qFjCHTDUDoipX7pZv+5SVXhegCDXaxuVrX72PQ@mail.gmail.com> (Daniel Pittman's message of "Mon, 7 Jan 2019 16:06:41 -0500")
I was fiddling with the reader when I found this:
/* FIXME: ?! When is this used !? */
return call1 (intern ("read-minibuffer"),
build_string ("Lisp expression: "));
This code is called when the reader is called from the minibuffer
*without a stream*, like this:
M-:
Eval: (read) RET
Lisp expression: ;; Insert elisp code here
A quick grep shows that "Lisp expression: " only occurs here in the
source code. There is a diff to fix the comment. This is my first
submission so I should be eligible, thank you.
--- lread.c 2019-06-29 21:50:46.506933174 -0700
+++ lread.c 2019-06-29 22:04:16.507921973 -0700
@@ -2209,7 +2209,8 @@
if (EQ (stream, Qt))
stream = Qread_char;
if (EQ (stream, Qread_char))
- /* FIXME: ?! When is this used !? */
+ /* This is used when calling (read) from the `eval-expression' minibuffer
+ with no stream. */
return call1 (intern ("read-minibuffer"),
build_string ("Lisp expression: "));
--
Spenser Truex
https://spensertruex.com/
San Francisco, USA
next prev parent reply other threads:[~2019-06-30 5:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 18:24 Licensing for source code contained in Emacs manuals Daniel Pittman
2018-11-12 20:01 ` Paul Eggert
2018-11-12 21:35 ` Daniel Pittman
2018-11-13 18:31 ` Glenn Morris
2018-11-14 23:13 ` Richard Stallman
2018-11-19 14:18 ` Daniel Pittman
2018-11-20 0:49 ` Richard Stallman
2018-12-24 2:26 ` Richard Stallman
2019-01-07 21:06 ` Daniel Pittman
2019-01-08 1:06 ` Paul Eggert
2019-01-08 18:57 ` Richard Stallman
2019-06-30 5:05 ` Spenser Truex [this message]
2019-06-30 13:50 ` FIXME: When the reader is called in the minibuffer Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9wn8xxq.fsf_-_@spensertruex.com \
--to=web@spensertruex.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.