From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Benjamin Ragheb" <ben@benzado.com>
Cc: 33984@debbugs.gnu.org
Subject: bug#33984: 26.1; fortune-compile does not search exec-path for strfile program
Date: Wed, 10 Jul 2019 00:32:28 +0200 [thread overview]
Message-ID: <87v9waq1oj.fsf@mouse.gnus.org> (raw)
In-Reply-To: <dac8fdc9-13e6-49be-b1ca-c00dee8518ef@www.fastmail.com> (Benjamin Ragheb's message of "Fri, 04 Jan 2019 21:54:28 -0500")
"Benjamin Ragheb" <ben@benzado.com> writes:
> I have attached a patch which corrects this problem by using
> executable-find before calling shell-command. If strfile cannot be
> found, it signals an error.
Makes sense.
> I tried to keep the patch as small as possible, and resisted the
> temptation to replace the call to shell-command with
> call-process. Doing so would have broken compatibility with the
> fortune-quiet-strfile-options variable, which people may have
> customized.
Yeah, that would be better, but would be incompatible as you say.
> - (concat fortune-file fortune-database-extension)))))
> + (concat fortune-file fortune-database-extension))))
> + (strfile (or (executable-find fortune-strfile)
> + (error "Can't find strfile program %s" fortune-strfile)))
> (cond ((file-exists-p fortune-file)
> (cond ((file-newer-than-file-p fortune-file fortune-dat)
> (message "Compiling new fortune database %s" fortune-dat)
> (shell-command
> - (concat fortune-strfile fortune-strfile-options
> + (concat strfile fortune-strfile-options
I've now applied this patch to the Emacs trunk.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2019-07-09 22:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-05 2:54 bug#33984: 26.1; fortune-compile does not search exec-path for strfile program Benjamin Ragheb
2019-07-09 22:32 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9waq1oj.fsf@mouse.gnus.org \
--to=larsi@gnus.org \
--cc=33984@debbugs.gnu.org \
--cc=ben@benzado.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.