From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#23597: 24.5; `cl-values-list' should not be an alias for `identity' Date: Sun, 28 Jul 2019 14:15:31 +0200 Message-ID: <87v9vmbbj0.fsf@mouse.gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="211155"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 23597@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 28 14:16:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hri5x-000spo-6f for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2019 14:16:09 +0200 Original-Received: from localhost ([::1]:45070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hri5w-0004Dn-7u for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2019 08:16:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48622) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hri5r-0004Da-L4 for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 08:16:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hri5q-0006Ov-Ii for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 08:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37069) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hri5q-0006OM-DR for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 08:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hri5q-0007d8-8U for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 08:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jul 2019 12:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23597 X-GNU-PR-Package: emacs Original-Received: via spool by 23597-submit@debbugs.gnu.org id=B23597.156431613827771 (code B ref 23597); Sun, 28 Jul 2019 12:16:02 +0000 Original-Received: (at 23597) by debbugs.gnu.org; 28 Jul 2019 12:15:38 +0000 Original-Received: from localhost ([127.0.0.1]:45887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hri5R-0007Dg-ST for submit@debbugs.gnu.org; Sun, 28 Jul 2019 08:15:38 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:54974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hri5Q-0007Au-7k for 23597@debbugs.gnu.org; Sun, 28 Jul 2019 08:15:36 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hri5L-0003q5-K8; Sun, 28 Jul 2019 14:15:34 +0200 In-Reply-To: (Drew Adams's message of "Sat, 21 May 2016 17:25:47 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163950 Archived-At: Drew Adams writes: > Emacs Lisp does not support multiple values for its Common Lisp > emulation. OK, fine. > > But that is not a reason for this kind of definition. > > `cl-values-list' should at least raise an error if its arg is not a > list. That too is part of the Common Lisp definition of `values-list': > "Should signal type-error if its argument is not a proper list." > > (cl-values-list 5) should not return 5. It should raise a wrong-type > arg error. I agree. I've gone through the Emacs trunk to see whether tightening up the definition would lead to any problems, but all the usages are on the form (cl-multiple-value-bind (tree header tree-buffer) (cl-values-list (ebrowse-choose-tree)) which would already bug out if what's returned is not a list. So I've now made this change on the trunk. In the unlikely case that this leads to problems with out-of-tree code, we should be open to reverting it. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no