From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: Question about dired-do-find-regexp and xref-collect-matches Date: Tue, 30 Jul 2019 10:22:28 -0700 Message-ID: <87v9vjv3mz.fsf@ericabrahamsen.net> References: <87a7dm6blt.fsf@ericabrahamsen.net> <0cf896c0-011a-ad4c-e661-b7763c7943c8@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="81024"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 30 19:24:20 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hsVrD-000KrZ-IY for ged-emacs-devel@m.gmane.org; Tue, 30 Jul 2019 19:24:15 +0200 Original-Received: from localhost ([::1]:34838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsVrC-0002DM-JF for ged-emacs-devel@m.gmane.org; Tue, 30 Jul 2019 13:24:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60834) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsVpg-0008Rv-KG for emacs-devel@gnu.org; Tue, 30 Jul 2019 13:22:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsVpd-0000jP-Na for emacs-devel@gnu.org; Tue, 30 Jul 2019 13:22:40 -0400 Original-Received: from 195-159-176-226.customer.powertech.no ([195.159.176.226]:32910 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hsVpd-0000hv-H6 for emacs-devel@gnu.org; Tue, 30 Jul 2019 13:22:37 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hsVpa-000ItB-Gu for emacs-devel@gnu.org; Tue, 30 Jul 2019 19:22:34 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:oslmjn/BxqSkGvZkiMjSBnQ7ZMI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239038 Archived-At: Dmitry Gutov writes: > Hi Eric, > > On 10.07.2019 2:18, Eric Abrahamsen wrote: >> A while ago I switched to the fish shell, which I generally like better >> than bash. > > I also like fish, a lot. I don't use it inside Emacs, though. Yeah, I just set Emacs' shell to bash, seems safer. >> While poking around I also noticed that dired-do-find-regexp calls >> xref-collect-matches once per marked file. That means a full find+grep >> call for each file, when a single find+grep call (or even just a single >> grep call!) would do the trick. > > That sounds like a bug report material. Up until now I figured a few > extra shell process calls wouldn't matter, but maybe they can. > > Just how many files are you marking in the given example? This was somewhere between 250-300 XML files. >> The search hits are collected as: >> >> (mapcan >> (lambda (file) >> (xref-collect-matches regexp "*" file >> (and (file-directory-p file) >> ignores))) >> files) >> >> But the second argument to `xref-collect-matches' can be a >> space-separated string of file names -- wouldn't it be easier just to >> call `xref-collect-matches' once? > > Not exactly. That FILES argument is something different (a list of globs). > > Overall, this shouldn't be too hard to fix. Could you send your > response to the bug tracker as a new report? Done, as bug#36857. Thanks for looking at this.