From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#34160: About commit bff64115a0ad081282e0f99305f41c8dd1917d67, bug#34160, json.el Date: Wed, 31 Jul 2019 22:21:10 +0200 Message-ID: <87v9vinefd.fsf__34157.7015978814$1564604535$gmane$org@mouse.gnus.org> References: <87ef26ac17.fsf@gnu.org> <87a7cuvyg3.fsf@mouse.gnus.org> <16c4982bea8.27dc.69bc538c4644581689883e654f15bce0@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="102067"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34160@debbugs.gnu.org, emacs-devel@gnu.org To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 31 22:22:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hsv6v-000QQd-Rr for geb-bug-gnu-emacs@m.gmane.org; Wed, 31 Jul 2019 22:22:09 +0200 Original-Received: from localhost ([::1]:44142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsv6u-0006Ip-Sz for geb-bug-gnu-emacs@m.gmane.org; Wed, 31 Jul 2019 16:22:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57055) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsv6p-0006IW-Kr for bug-gnu-emacs@gnu.org; Wed, 31 Jul 2019 16:22:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsv6o-0000ep-9Y for bug-gnu-emacs@gnu.org; Wed, 31 Jul 2019 16:22:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44324) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hsv6o-0000ej-6l for bug-gnu-emacs@gnu.org; Wed, 31 Jul 2019 16:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hsv6o-0002gf-0V for bug-gnu-emacs@gnu.org; Wed, 31 Jul 2019 16:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 Jul 2019 20:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34160 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 34160-submit@debbugs.gnu.org id=B34160.156460447910258 (code B ref 34160); Wed, 31 Jul 2019 20:22:01 +0000 Original-Received: (at 34160) by debbugs.gnu.org; 31 Jul 2019 20:21:19 +0000 Original-Received: from localhost ([127.0.0.1]:53145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsv66-0002fL-Nd for submit@debbugs.gnu.org; Wed, 31 Jul 2019 16:21:18 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:55148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsv63-0002f5-HW for 34160@debbugs.gnu.org; Wed, 31 Jul 2019 16:21:15 -0400 Original-Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hsv5z-00005z-Dw; Wed, 31 Jul 2019 22:21:13 +0200 In-Reply-To: <16c4982bea8.27dc.69bc538c4644581689883e654f15bce0@gnu.org> (Tassilo Horn's message of "Wed, 31 Jul 2019 21:30:12 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164187 Archived-At: Tassilo Horn writes: > It's not just moving point. replace-region-contents also keeps marks, > text properties and fontification intact. So we should definitely be > using it here. Ah, I see. I only gave that function a cursory look-over when fixing this bug and I didn't quite understand what it was doing here, since I couldn't recall any other pretty-printer doing anything similar. Sorry for the confusion here; I've now restored the replace-region-contents logic. Or at least I think so; it works with the test cases in this bug report, at least. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no