From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: bug#34160: About commit bff64115a0ad081282e0f99305f41c8dd1917d67, bug#34160, json.el Date: Wed, 31 Jul 2019 22:21:10 +0200 Message-ID: <87v9vinefd.fsf@mouse.gnus.org> References: <87ef26ac17.fsf@gnu.org> <87a7cuvyg3.fsf@mouse.gnus.org> <16c4982bea8.27dc.69bc538c4644581689883e654f15bce0@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="100705"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34160@debbugs.gnu.org, emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 31 22:21:48 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hsv6Y-000Py4-R0 for ged-emacs-devel@m.gmane.org; Wed, 31 Jul 2019 22:21:46 +0200 Original-Received: from localhost ([::1]:44136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsv6X-0005Xs-CP for ged-emacs-devel@m.gmane.org; Wed, 31 Jul 2019 16:21:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56838) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsv68-0005Xd-Kf for emacs-devel@gnu.org; Wed, 31 Jul 2019 16:21:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsv64-0000Ev-Ca for emacs-devel@gnu.org; Wed, 31 Jul 2019 16:21:18 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:49568) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hsv64-0000EE-5V; Wed, 31 Jul 2019 16:21:16 -0400 Original-Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hsv5z-00005z-Dw; Wed, 31 Jul 2019 22:21:13 +0200 In-Reply-To: <16c4982bea8.27dc.69bc538c4644581689883e654f15bce0@gnu.org> (Tassilo Horn's message of "Wed, 31 Jul 2019 21:30:12 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239060 Archived-At: Tassilo Horn writes: > It's not just moving point. replace-region-contents also keeps marks, > text properties and fontification intact. So we should definitely be > using it here. Ah, I see. I only gave that function a cursory look-over when fixing this bug and I didn't quite understand what it was doing here, since I couldn't recall any other pretty-printer doing anything similar. Sorry for the confusion here; I've now restored the replace-region-contents logic. Or at least I think so; it works with the test cases in this bug report, at least. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no