From: Lars Ingebrigtsen <larsi@gnus.org>
To: Tassilo Horn <tsdh@gnu.org>
Cc: 34160@debbugs.gnu.org, emacs-devel@gnu.org
Subject: Re: bug#34160: About commit bff64115a0ad081282e0f99305f41c8dd1917d67, bug#34160, json.el
Date: Wed, 31 Jul 2019 22:21:10 +0200 [thread overview]
Message-ID: <87v9vinefd.fsf@mouse.gnus.org> (raw)
In-Reply-To: <16c4982bea8.27dc.69bc538c4644581689883e654f15bce0@gnu.org> (Tassilo Horn's message of "Wed, 31 Jul 2019 21:30:12 +0200")
Tassilo Horn <tsdh@gnu.org> writes:
> It's not just moving point. replace-region-contents also keeps marks,
> text properties and fontification intact. So we should definitely be
> using it here.
Ah, I see. I only gave that function a cursory look-over when fixing
this bug and I didn't quite understand what it was doing here, since I
couldn't recall any other pretty-printer doing anything similar.
Sorry for the confusion here; I've now restored the
replace-region-contents logic. Or at least I think so; it works with
the test cases in this bug report, at least.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-07-31 20:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 17:46 bug#34160: json-pretty-print deletes everything after first JSON object Albert Heinle
2019-07-09 18:41 ` Lars Ingebrigtsen
2019-07-10 8:53 ` Glenn Morris
2019-07-10 11:24 ` Lars Ingebrigtsen
2019-07-31 7:39 ` About commit bff64115a0ad081282e0f99305f41c8dd1917d67, bug#34160, json.el Tassilo Horn
2019-07-31 15:38 ` bug#34160: " Eli Zaretskii
2019-07-31 15:38 ` Eli Zaretskii
2019-07-31 18:40 ` Tassilo Horn
2019-07-31 18:40 ` Tassilo Horn
2019-07-31 18:48 ` Eli Zaretskii
2019-07-31 18:48 ` Eli Zaretskii
2019-07-31 18:41 ` Lars Ingebrigtsen
2019-07-31 18:41 ` Lars Ingebrigtsen
2019-07-31 19:30 ` Tassilo Horn
2019-07-31 19:30 ` Tassilo Horn
2019-07-31 20:21 ` Lars Ingebrigtsen [this message]
2019-08-01 4:54 ` Tassilo Horn
2019-08-01 4:54 ` Tassilo Horn
2019-08-01 11:11 ` Lars Ingebrigtsen
2019-08-01 12:16 ` Tassilo Horn
2019-08-02 16:16 ` Tassilo Horn
2019-08-02 16:16 ` Tassilo Horn
2019-08-01 12:16 ` Tassilo Horn
2019-08-01 11:11 ` Lars Ingebrigtsen
2019-07-31 20:21 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9vinefd.fsf@mouse.gnus.org \
--to=larsi@gnus.org \
--cc=34160@debbugs.gnu.org \
--cc=emacs-devel@gnu.org \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.