From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#36916: 27.0.50; bug-reference: Make push button action customizable Date: Sun, 04 Aug 2019 14:03:29 +0200 Message-ID: <87v9vd3zou.fsf@web.de> References: <87h86xek71.fsf@web.de> <875zndi40y.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="181562"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 36916@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 04 14:04:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1huFFA-000l5h-UC for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Aug 2019 14:04:09 +0200 Original-Received: from localhost ([::1]:44248 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huFFA-00076c-09 for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Aug 2019 08:04:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41114) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huFF5-00076D-9B for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 08:04:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1huFF4-0000V9-BI for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 08:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51896) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1huFF4-0000Uy-4S for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 08:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1huFF3-0004gJ-TA for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 08:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Aug 2019 12:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36916 X-GNU-PR-Package: emacs Original-Received: via spool by 36916-submit@debbugs.gnu.org id=B36916.156492022317971 (code B ref 36916); Sun, 04 Aug 2019 12:04:01 +0000 Original-Received: (at 36916) by debbugs.gnu.org; 4 Aug 2019 12:03:43 +0000 Original-Received: from localhost ([127.0.0.1]:60717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huFEk-0004fn-Rh for submit@debbugs.gnu.org; Sun, 04 Aug 2019 08:03:43 -0400 Original-Received: from mout.web.de ([212.227.17.12]:40135) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huFEg-0004fV-O2 for 36916@debbugs.gnu.org; Sun, 04 Aug 2019 08:03:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1564920212; bh=y1q8wvVya2Qbtdh6a6d32SctiOYEiGvQ5v98QrQaSYo=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=UqzC57pi6dYdsKW+ZvY7HbUxv4JbKkZlTjgPYybYt33PnlecAP06PYUemVPYm7/Y3 FPsiCFwuvQCEUq9xe+lKv2Kpa9RzLwPD9z8XvjdtWqZ+G6VhYD8mcgT4vN6EO3/ou4 82V+62yNiLraE0zABzHFO+jj7I2fyG+QNHjLiMJk= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([92.208.178.242]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LudKu-1iKTGW1coq-00zmiv; Sun, 04 Aug 2019 14:03:32 +0200 In-Reply-To: <875zndi40y.fsf@gmx.de> (Michael Albinus's message of "Sun, 04 Aug 2019 13:06:05 +0200") X-Provags-ID: V03:K1:EvK6Vc/S1Ysm/fhm4j6Tfm3j7l30S/PJOBqfyLq20kAVxUDv3Mc hqimDoTKSX5ZDKDdldY+21lu6d4ddbzwCNkQ9JGRhVR6DKGMSLX78noy3lXNH2YxTT5G4t8 Eg7BcywffME9MV/hVVk06zmVW6sY6mR/ZsmRd1QjGZkyTPHzatHnCsBxEkJw6rHiSZQqCRc Jp5Ko5NaKHodj5ErodnwA== X-UI-Out-Filterresults: notjunk:1;V03:K0:vhm+U/N226o=:6dhMlDbPw3eNmnIBhmqy6y RQlpmps8PXp6AANilVThWSG6wg9SCIgGttnUfYMI9zzOR+/i5YJcXQT5Js6gqPExAalf/CwG5 39w++rqUjQZIK/sN//VBa0ySLTMh87yOXvPHhRqRdR3bRU47dlYqDR9U5fdYnE3VF4UAuTwHT ptAJ2LWfp6Uzd+dY1V7y+lrJvKDSCD5hpmtjyoxKFmGsQgU+aVDAXP/HnKL4MJB4EQmd29o6j +XvVphdgK5cQeRmm8omKS5a5FuOAHnTg1hVGdDMIoTogVxRsU4eIO0vlfKA/ufvXpFetizQmZ /167JhyEimVsVWdogJYn41ZHBYzBfdI2ko6q7jTEvrmJ7YXKUUbTmVnvEdkmAfEaP9upxw+J0 Z61wUV2xGd0uYxMaNf6oSoa0GohKV9ObDq4hzYxhRx4AuRGKpRUsAZSokriwQo57o8xKZ+isU 7iHqsuIKC3m+rwSGU1M0WT45l3iUGfwT+36zp5tOoVi3BC5/mtZkXUoC09jS+92lxVBS/Lpra uQZBoDHLH4mH6UY12mhQpkvsQ2oNDSB19l53reM1fQ9H3k52ZN8UAV9WL/SG2bPAPnyEPKhcI GVSsylqwSkJWN1uR6DS1Z7PVjard1mlS+j479jGOzviC3YweA0WJu2LlBsAkWy8R5rnwDTO0G QEVxPjTiZnTouYib9mTy6sc4OJzKbusrnoV6GFIdIrcOni1ppY1aIcyKLGhe4j+Vu8p2EvfNN eQCWgmVDnDnHBNDbpp+NMB4x6vjkLc1b4oCdlnMnFPpJJvyEMlwMsYXUbh5etp33wP//7GBe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164553 Archived-At: Michael Albinus writes: > There is the minor mode `debbugs-browse-mode'. Enable it, that's it. Hmm, ok. But it's only a minor mode, so instead of having a global setting, I have to add that minor mode to any place where it's needed. So, why this does what I want, it's a bit disappointing: bug-reference hardcodes browse-url, and browse-url can't be changed to handle new types of urls specially, so the only thing we can do is to hijack browse-url-browser-function buffer-locally. Can't this even have side effects? What if the Magit revision buffer includes real links? Oh - no, I see, that works because the minor mode uses an :before-until advice. But it will break if something else binds or sets browse-url-browser-function, right? Michael.