From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#25191: Redesign `recentf-menu-bar' logic and its callers Date: Wed, 09 Oct 2019 09:46:16 +0200 Message-ID: <87v9sypdiv.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="182351"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 25191@debbugs.gnu.org To: Alexander Shukaev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 09 18:53:31 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIFDO-000lIL-6y for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 18:53:30 +0200 Original-Received: from localhost ([::1]:52594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIFDM-00021C-3b for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 12:53:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41709) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iI6gZ-0002fW-4m for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 03:47:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iI6gY-0007WU-1k for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 03:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43209) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iI6gX-0007WM-Um for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 03:47:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iI6gX-0003HP-RA for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 03:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Oct 2019 07:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25191 X-GNU-PR-Package: emacs Original-Received: via spool by 25191-submit@debbugs.gnu.org id=B25191.157060718410708 (code B ref 25191); Wed, 09 Oct 2019 07:47:01 +0000 Original-Received: (at 25191) by debbugs.gnu.org; 9 Oct 2019 07:46:24 +0000 Original-Received: from localhost ([127.0.0.1]:52027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6fu-0002kI-Hm for submit@debbugs.gnu.org; Wed, 09 Oct 2019 03:46:24 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:56516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6ft-0002iY-5f for 25191@debbugs.gnu.org; Wed, 09 Oct 2019 03:46:21 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iI6fo-0004ZZ-Tk; Wed, 09 Oct 2019 09:46:19 +0200 In-Reply-To: (Alexander Shukaev's message of "Tue, 13 Dec 2016 01:59:34 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168718 Archived-At: Alexander Shukaev writes: > (defsubst recentf-menu-bar () > "Return the keymap of the global menu bar." > (lookup-key global-map [menu-bar])) > > (defun recentf-show-menu () > "Show the menu of recently opened files." > (easy-menu-add-item > (recentf-menu-bar) recentf-menu-path > (list recentf-menu-title :filter 'recentf-make-menu-items) > recentf-menu-before)) > > (defun recentf-hide-menu () > "Hide the menu of recently opened files." > (easy-menu-remove-item (recentf-menu-bar) recentf-menu-path > recentf-menu-title)) > > from 'recentf.el'. This code is ill-formed. When `global-map' is > customized in such a way that it does not have `(kbd "")' > (or `[menu-bar]'), then both `recentf-show-menu' and > `recentf-hide-menu' will fail. I've now added checks to protect against this in Emacs 27. > Furthermore, according to Emacs documentation, using > `(current-global-map)' is more correct than `global-map'. That's true, but I think fixing that is more a matter of somebody grepping and replacing rather than fixing piecemeal, perhaps... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no