all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ingo Lohmar <ingo.lohmar@posteo.net>
To: emacs-devel@gnu.org
Subject: [BUG] Tabs and mode/header/frame-title update
Date: Sun, 20 Oct 2019 16:26:03 +0200	[thread overview]
Message-ID: <87v9sjjxxg.fsf@kenko.localhost.com> (raw)


Tabs are working great, but here is one minor thing I stumbled about,
and that eventually led me to a bug:

1) The bug is: at the end of `tab-bar-rename-tab`, it should read

@@ -687,7 +687,7 @@ tab-bar-rename-tab
                          (funcall tab-bar-tab-name-function))))
     (setf (cdr (assq 'name tab-to-rename)) tab-new-name
           (cdr (assq 'explicit-name tab-to-rename)) tab-explicit-name)
-    (if (tab-bar-mode)
+    (if tab-bar-mode
         (force-mode-line-update)
       (message "Renamed tab to '%s'" tab-new-name))))
 
so as not to turn on `tab-bar-mode`, but only to check its status.

2) However, I use tabs w/o tab-bar-mode and only looked at the code
above because I wondered why my frame-title (where I put the current tab
info) was not reliably updated when, eg, adding a tab.

IMO, such an update is *especially* relevant when you use the functions
without `tab-bar-mode`.  But all calls to `force-mode-line-update` (at
the end of various interactive functions) are conditioned on
`tab-bar-mode`.

Since this is by no means a frequent operation, I strongly suggest
to update the modeline(/header/title) unconditionally.



             reply	other threads:[~2019-10-20 14:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-20 14:26 Ingo Lohmar [this message]
2019-10-20 16:31 ` [BUG] Tabs and mode/header/frame-title update Juri Linkov
2019-10-20 16:49   ` Ingo Lohmar
2019-10-20 20:55     ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9sjjxxg.fsf@kenko.localhost.com \
    --to=ingo.lohmar@posteo.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.