From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: 35564@debbugs.gnu.org
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
Noam Postavsky <npostavs@gmail.com>,
Juri Linkov <juri@linkov.net>,
Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#35564: [PATCH v5] Tweak dired warning about "wildcard" characters
Date: Tue, 22 Oct 2019 17:10:54 +0200 [thread overview]
Message-ID: <87v9sgrf29.fsf@gmail.com> (raw)
In-Reply-To: <87o8yoign9.fsf_-_@gmail.com> ("Kévin Le Gouguec"'s message of "Thu, 10 Oct 2019 20:45:14 +0200")
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
Casual and nonchalant bump.
I realize that everyone has their plate full right now (Emacs has tabs!
Face extension beyond EOL is customizable! What a time to be alive!),
so I am not expecting this to get any immediate attention. In case it
helps though, here is a comparison when running e.g. sed 's/?/!/':
Old prompt:
> Confirm--do you mean to use ‘?’ as a wildcard? (y or n)
New prompt based on read-multiple-choice:
> Warning: 1 occurrence of ‘?’ will not be substituted. Proceed?
> ([Y]es, [N]o, toggle [D]etails, [?]):
Hitting 'd' pops a buffer showing more information[1]. The commands
then become:
> ([Y]es, [N]o, toggle [D]etails, toggle [M]arkers, [?])
Hitting 'm' shows/hides '^' markers below the occurrences; 'd' quits the
details window.
Screenshots in GUI session:
[-- Attachment #2: gui-basic.png --]
[-- Type: image/png, Size: 151116 bytes --]
[-- Attachment #3: gui-details.png --]
[-- Type: image/png, Size: 122107 bytes --]
[-- Attachment #4: gui-markers.png --]
[-- Type: image/png, Size: 121981 bytes --]
[-- Attachment #5: Type: text/plain, Size: 22 bytes --]
Screenshots in TTY:
[-- Attachment #6: tty-basic.png --]
[-- Type: image/png, Size: 12101 bytes --]
[-- Attachment #7: tty-details.png --]
[-- Type: image/png, Size: 11785 bytes --]
[-- Attachment #8: tty-markers.png --]
[-- Type: image/png, Size: 11779 bytes --]
[-- Attachment #9: Type: text/plain, Size: 907 bytes --]
The patch(es) can be found in my previous message[2] (along with some
context and rationale). Let me know if there is anything I can do to
help with the review.
Thank you for your time.
[1] Contents of the details buffer:
> If your command contains occurrences of ‘*’ surrounded by
> whitespace, ‘dired-do-shell-command’ substitutes them for the
> entire file list to process. Otherwise, if your command contains
> occurrences of ‘?’ surrounded by whitespace or ‘`’, Dired will
> run the command once for each file, substituting ‘?’ for each
> file name.
>
> Your command contains occurrences of ‘?’ that will not be
> substituted, and will be passed through normally to the shell.
>
> sed 's/?/!/'
'?' is highlighted with the warning face.
[2] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35564#157
next prev parent reply other threads:[~2019-10-22 15:10 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 18:01 bug#35564: 27.0.50; [PATCH] Tweak dired-do-shell-command warning about "wildcard" characters Kévin Le Gouguec
2019-05-05 8:44 ` martin rudalics
2019-05-06 19:40 ` Kévin Le Gouguec
2019-05-07 8:15 ` martin rudalics
2019-05-07 13:19 ` Drew Adams
2019-05-08 20:42 ` Kévin Le Gouguec
2019-05-08 22:39 ` Drew Adams
2019-05-09 8:13 ` martin rudalics
2019-05-09 14:17 ` Drew Adams
2019-05-09 17:51 ` martin rudalics
2019-05-09 20:04 ` Drew Adams
2019-06-09 11:08 ` bug#35564: [PATCH v2] Tweak dired " Kévin Le Gouguec
2019-06-12 12:23 ` Noam Postavsky
2019-06-12 14:29 ` Stefan Monnier
2019-06-13 6:19 ` Kévin Le Gouguec
2019-06-13 7:58 ` Stefan Monnier
2019-06-13 16:53 ` npostavs
2019-06-18 8:52 ` Kévin Le Gouguec
2019-06-19 0:12 ` Noam Postavsky
2019-06-26 6:16 ` bug#35564: [PATCH v3] " Kévin Le Gouguec
2019-06-26 13:27 ` Drew Adams
2019-06-27 5:58 ` Kévin Le Gouguec
2019-06-26 14:33 ` Stefan Monnier
2019-06-27 6:15 ` Kévin Le Gouguec
2019-06-27 23:31 ` Noam Postavsky
2019-06-28 6:15 ` Kévin Le Gouguec
2019-06-28 15:35 ` Drew Adams
2019-06-28 17:58 ` Kévin Le Gouguec
2019-06-28 18:43 ` Drew Adams
2019-06-29 13:48 ` Noam Postavsky
2019-06-29 14:30 ` Drew Adams
2019-06-29 14:13 ` Eli Zaretskii
2019-07-03 19:47 ` bug#35564: [PATCH v4] " Kévin Le Gouguec
2019-07-12 15:10 ` Kévin Le Gouguec
2019-07-27 11:20 ` Eli Zaretskii
2019-07-27 17:26 ` Kévin Le Gouguec
2019-07-27 22:22 ` Michael Heerdegen
2019-07-29 3:29 ` Michael Heerdegen
2019-07-29 18:11 ` Juri Linkov
2019-07-29 19:01 ` Kévin Le Gouguec
2019-08-02 5:26 ` Michael Heerdegen
2019-08-08 10:40 ` Kévin Le Gouguec
2019-08-08 21:06 ` Juri Linkov
2019-08-09 12:43 ` Kévin Le Gouguec
2019-08-09 18:03 ` Juri Linkov
2019-08-15 20:56 ` Juri Linkov
2019-08-19 4:55 ` Kévin Le Gouguec
2019-07-27 22:03 ` Basil L. Contovounesios
2019-07-27 23:32 ` Kévin Le Gouguec
2019-07-27 23:41 ` Basil L. Contovounesios
2019-10-10 18:45 ` bug#35564: [PATCH v5] " Kévin Le Gouguec
2019-10-22 15:10 ` Kévin Le Gouguec [this message]
2019-10-22 16:58 ` Michael Heerdegen
2019-10-22 21:32 ` Kévin Le Gouguec
2019-11-10 20:29 ` Juri Linkov
2019-11-14 7:02 ` Kévin Le Gouguec
2019-11-16 20:23 ` Juri Linkov
2019-10-22 20:43 ` Juri Linkov
2019-10-22 21:11 ` Kévin Le Gouguec
2019-10-27 21:40 ` Juri Linkov
2019-10-30 21:59 ` Juri Linkov
2019-11-04 6:36 ` Kévin Le Gouguec
2019-11-05 22:22 ` Juri Linkov
2019-11-07 22:17 ` Juri Linkov
2019-11-10 20:18 ` Juri Linkov
2019-12-18 7:11 ` Kévin Le Gouguec
2019-12-19 22:01 ` Juri Linkov
2019-12-20 8:53 ` Eli Zaretskii
2019-12-20 20:34 ` Kévin Le Gouguec
2019-12-21 7:08 ` Eli Zaretskii
2019-12-22 16:02 ` Kévin Le Gouguec
2019-12-20 20:43 ` Kévin Le Gouguec
2019-12-21 7:08 ` Eli Zaretskii
2020-09-20 11:42 ` Lars Ingebrigtsen
2020-09-20 12:04 ` Kévin Le Gouguec
2020-09-20 12:18 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9sgrf29.fsf@gmail.com \
--to=kevin.legouguec@gmail.com \
--cc=35564@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.