From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#17064: 24.3.50; Enhancement request: dired: fontification of symlinks Date: Thu, 31 Oct 2019 00:33:02 +0100 Message-ID: <87v9s5n70x.fsf@gnus.org> References: <87siqb6s9i.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="27971"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 17064@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 31 00:34:31 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPxTz-000798-3l for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Oct 2019 00:34:31 +0100 Original-Received: from localhost ([::1]:45384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPxTx-0001LO-EH for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Oct 2019 19:34:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51243) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPxTX-0001Dp-Iw for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 19:34:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPxTW-0005Yx-Aw for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 19:34:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43069) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iPxTW-0005Yh-7a for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 19:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iPxTW-0004gF-2o for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 19:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Oct 2019 23:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17064 X-GNU-PR-Package: emacs Original-Received: via spool by 17064-submit@debbugs.gnu.org id=B17064.157247838917868 (code B ref 17064); Wed, 30 Oct 2019 23:34:02 +0000 Original-Received: (at 17064) by debbugs.gnu.org; 30 Oct 2019 23:33:09 +0000 Original-Received: from localhost ([127.0.0.1]:51887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPxSe-0004e8-W2 for submit@debbugs.gnu.org; Wed, 30 Oct 2019 19:33:09 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:36262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPxSc-0004du-Ux for 17064@debbugs.gnu.org; Wed, 30 Oct 2019 19:33:07 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPxSY-0008M6-Rx; Thu, 31 Oct 2019 00:33:05 +0100 In-Reply-To: <87siqb6s9i.fsf@web.de> (Michael Heerdegen's message of "Sat, 22 Mar 2014 00:34:01 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170490 Archived-At: Michael Heerdegen writes: > in dired, symlinks look like > > symlink -> target > > where the whole thing is fontified with dired-symlink-face. But I > already know from the -> that I have a symlink, it would be more useful > to know whether TARGET is a directory, which is what I normally see for > non symlink files in dired by fontification with dired-directory-face. > > My proposal: fontify only the first part "symlink ->" with > dired-symlink-face. Fontify "target" according to its truename type. Sounds good to me. > (cl-callf nconc dired-font-lock-keywords > `((,dired-re-sym > ((lambda (end) (when (let ((file (dired-file-name-at-point))) > (file-directory-p (file-truename file))) > (search-forward-regexp "\\(.+-> ?\\)\\(.+\\)" end t))) > (dired-move-to-filename) > nil > (1 dired-symlink-face) > (2 dired-directory-face))) [...] > Or could this have any bad side effects? Is it maybe too heavy to call > `file-truename'? Normally, there aren't many symlinks in a buffer, so I think the performance impact would be negligible. I've added a modified version of your code to Emacs 27 -- more error checking was necessary, because symlinks may be circular etc. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no