From: Lars Ingebrigtsen <larsi@gnus.org>
To: martin rudalics <rudalics@gmx.at>
Cc: Andrii Kolomoiets <andreyk.mad@gmail.com>, 38216@debbugs.gnu.org
Subject: bug#38216: [PATCH] vc-hg: don't pass empty string to 'update' command
Date: Fri, 15 Nov 2019 10:05:27 +0100 [thread overview]
Message-ID: <87v9rljyqw.fsf@gnus.org> (raw)
In-Reply-To: <3450b6e8-f9ee-a4b2-a286-bcf250b35892@gmx.at> (martin rudalics's message of "Fri, 15 Nov 2019 09:59:38 +0100")
martin rudalics <rudalics@gmx.at> writes:
>> Thanks; applied the patch to Emacs 27.
>
> Gets me
>
> ../../lisp/vc/vc-hg.el:1467:1:Warning: the function `string-empty-p' is not
> known to be defined.
>
> here.
Huh; my patch applying function is supposed to do a byte compilation to
catch bugs like that... but I must have forgotten to actually look at
it.
I've now changed it to avoid this subr-x function.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2019-11-15 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 7:51 bug#38216: [PATCH] vc-hg: don't pass empty string to 'update' command Andrii Kolomoiets
2019-11-15 8:14 ` Lars Ingebrigtsen
2019-11-15 8:59 ` martin rudalics
2019-11-15 9:05 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9rljyqw.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=38216@debbugs.gnu.org \
--cc=andreyk.mad@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.