From: Yuri D'Elia <wavexx@thregr.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 5ee43ba0df causing display hangs?
Date: Wed, 11 Dec 2019 12:36:52 +0100 [thread overview]
Message-ID: <87v9qnayaz.fsf@wavexx.thregr.org> (raw)
In-Reply-To: <19062F8F-0969-4ADD-87E5-F67443D376F2@gnu.org>
On Tue, Dec 10 2019, Eli Zaretskii wrote:
> Thanks.
>
> Please show the face that is refetenced in frame #5 as face_name, and
> all its attributes. AFAIU, this is the original face being merged
> here.
>
> The 'quote' thing probably means some attribute is redundantly quoted,
> but maybe I'm missing something.
That's indeed the problem.
#1 0x00005555556e1b2e in merge_named_face (w=0x5555577d4990, f=0x55555617e280,
face_name=XIL(0x1154e20), to=0x7fffffff67f0, named_merge_points=0x7fffffff62d0,
attr_filter=LFACE_EXTEND_INDEX) at xfaces.c:2223
(gdb) pp face_name
gnus-header-content
gnus-header-content inherits indeed a redundant quote:
((:family . unspecified) (:foundry . unspecified) (:width . unspecified)
(:height . unspecified) (:weight . unspecified) (:slant . unspecified)
(:underline . unspecified) (:overline . unspecified) (:extend . unspecified)
(:strike-through . unspecified) (:box . unspecified) (:inverse-video . unspecified)
(:foreground . unspecified) (:background . unspecified) (:stipple . unspecified)
(:inherit quote mu4e-header-value-face))
I've found where I had this incorrectly set. After removing the quote
the loop properly terminates.
So it looks like a good fix would be first to ensure a failure in the
inner for loop in get_lface_attributes properly terminates. And also to
check for an explicit face symbol in inherit?
next prev parent reply other threads:[~2019-12-11 11:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-07 13:08 master 5ee43ba0df causing display hangs? Yuri D'Elia
2019-12-07 17:42 ` Eli Zaretskii
2019-12-07 18:14 ` Eli Zaretskii
2019-12-07 18:56 ` Yuri D'Elia
2019-12-07 19:18 ` Eli Zaretskii
2019-12-07 23:03 ` Yuri D'Elia
2019-12-08 15:55 ` Eli Zaretskii
2019-12-08 16:03 ` Yuri D'Elia
2019-12-08 16:57 ` Eli Zaretskii
2019-12-10 10:57 ` Yuri D'Elia
2019-12-10 12:01 ` Eli Zaretskii
2019-12-11 11:36 ` Yuri D'Elia [this message]
2019-12-11 17:14 ` Eli Zaretskii
2019-12-11 17:29 ` Yuri D'Elia
2019-12-11 17:47 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9qnayaz.fsf@wavexx.thregr.org \
--to=wavexx@thregr.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.