From: Juri Linkov <juri@linkov.net>
To: Alexander Shukaev <emacs@Alexander.Shukaev.name>
Cc: 39015@debbugs.gnu.org
Subject: bug#39015: `isearch-complete1' should use `completion-at-point' or `completion-in-region'
Date: Mon, 20 Jan 2020 02:27:06 +0200 [thread overview]
Message-ID: <87v9p7km5h.fsf@mail.linkov.net> (raw)
In-Reply-To: <7da1738e-1e8a-3c12-31bf-741ee171db5c@Alexander.Shukaev.name> (Alexander Shukaev's message of "Tue, 7 Jan 2020 17:19:29 +0100")
> Not sure why in the first place `isearch-complete1' uses some custom
> auto-completion implementation that is different from a conventional
> solution, perhaps historical reasons. Thus, I believe that reusing either
> `completion-at-point' or `completion-in-region' to implement that
> functionality is much better in the long run. This would also allow
> packages, which customize completion behavior, to hook into `isearch'
> auto-completion as well. See also [1] for example.
>
> [1] https://github.com/abo-abo/swiper/issues/1882
Based on this solution
https://lists.gnu.org/archive/html/emacs-devel/2020-01/msg00447.html
it should be possible to write a patch that would hook into `isearch'
auto-completion. I seems I can't do this since I don't understand
how to test it.
prev parent reply other threads:[~2020-01-20 0:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 16:19 bug#39015: `isearch-complete1' should use `completion-at-point' or `completion-in-region' Alexander Shukaev
2020-01-12 23:36 ` `isearch-complete1' should use `completion-at-point' or `completion-in-region' (was: bug#39015) Juri Linkov
2020-01-13 14:35 ` `isearch-complete1' should use `completion-at-point' or `completion-in-region' Alexander Shukaev
2020-01-13 19:38 ` Stefan Monnier
2020-01-14 23:51 ` Juri Linkov
2020-01-15 13:57 ` Stefan Monnier
2020-01-15 23:24 ` Juri Linkov
2020-01-20 0:27 ` Juri Linkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9p7km5h.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=39015@debbugs.gnu.org \
--cc=emacs@Alexander.Shukaev.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.