From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Felician Nemeth Newsgroups: gmane.emacs.bugs Subject: bug#39190: 28.0.50; two buffers with same buffer-file-name (diff-syntax-fontify-props) Date: Thu, 30 Jan 2020 20:48:33 +0100 Message-ID: <87v9os914e.fsf@betli.tmit.bme.hu> References: <875zh73dg8.fsf@betli.tmit.bme.hu> <8736c921s6.fsf@mail.linkov.net> <875zh13e5d.fsf@mail.linkov.net> <87h80iqafm.fsf@betli.tmit.bme.hu> <87ftg0fnyb.fsf@mail.linkov.net> <87d0b3qz3m.fsf@betli.tmit.bme.hu> <871rrhkgkm.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="89373"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 39190@debbugs.gnu.org, Stefan Monnier To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 30 20:49:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ixFoN-000NCQ-PK for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Jan 2020 20:49:11 +0100 Original-Received: from localhost ([::1]:38374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixFoM-0002OL-Pb for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Jan 2020 14:49:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47669) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixFoF-0002Nr-7F for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 14:49:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixFoE-0007qu-A2 for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 14:49:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58535) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ixFoE-0007qU-6x for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 14:49:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ixFoE-00074y-5w for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 14:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Felician Nemeth Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Jan 2020 19:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39190 X-GNU-PR-Package: emacs Original-Received: via spool by 39190-submit@debbugs.gnu.org id=B39190.158041372527188 (code B ref 39190); Thu, 30 Jan 2020 19:49:02 +0000 Original-Received: (at 39190) by debbugs.gnu.org; 30 Jan 2020 19:48:45 +0000 Original-Received: from localhost ([127.0.0.1]:36275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixFnw-00074S-P5 for submit@debbugs.gnu.org; Thu, 30 Jan 2020 14:48:44 -0500 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:34404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixFnv-00074G-Hw for 39190@debbugs.gnu.org; Thu, 30 Jan 2020 14:48:43 -0500 Original-Received: by mail-wr1-f54.google.com with SMTP id t2so5663500wrr.1 for <39190@debbugs.gnu.org>; Thu, 30 Jan 2020 11:48:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:face:mime-version; bh=Sf/n+8Fgiin1OaxR67rcFzoSjf0mI/k67Zb2v5/u1ps=; b=jRQ0w8lTf4x3bsw18yCxC4Z43t2qOmHHyCEeQmVR8Evhmy4il5og0NcpUtzGUAjbUP AH8LoNYMrIBkMvK4EJ1LyuUqVbZtezcLhv1BXOwixyf3pT6nQkGwGMUaHNOVHT95lCZt TlinCcAe/W67qPa74lVOM+Q+09kwZyVcudXPtuzumy4/wGbfQwcY8ggwcHDqHyLk7IdK hFZGJSHP3sIPxLsR5q0ntYpbaZHiyiPTbntiUWZIUQynZX4Vr+7RvETAZx0+Io2/1IMJ 147vB1OYYIfvTttuarFnJRjgalUrf49kTu9figPg9DrAZXL6RuvtxIz4p42bRjUryuas OGsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:face:mime-version; bh=Sf/n+8Fgiin1OaxR67rcFzoSjf0mI/k67Zb2v5/u1ps=; b=kocBntFEDcjNZAnawjMbx1uRLoizufqC8Nty6kAzWnMNMJPBrnO9lu9DUEFIbFtRON IvMlwEVbFKR2P3xplwitsOVXgTPDQU69G2vHwuQ6NhaOP3ISuf/fd4rR0GPAAC1wCqx/ bm6UGMGOXU1llNDahwOOnihpuTsjOD+Bg+cJ47tS8KEDnDtHBv/ZdkmAjJev9/PapITj XimVhr439lQknq4IMa5q1HVsry0DkoWqQJXNZf1XQ7Gpjh3bEBkGGlDWk3uIRwjh0ybe 810eILFoQr4xCiGGCqWqpdcKoBIFh8UzcHWZmFngHuaE+S2lDOyjCfOdAHCtcvcgCDeR ybmw== X-Gm-Message-State: APjAAAUNWVMQ8M+LO3daiOJEbS/8DbHwlBtTka19KW5tE28ME9kDS48v vlXVE1ulPLFt6nORggPHquz0r5ak X-Google-Smtp-Source: APXvYqw2E2QEkp4hKS0MCJdMTRZGhftlyTu1RkfmRskqGl7kbC0ZMMx9Ld5okHGCIOnA0T1i54gduA== X-Received: by 2002:adf:ea06:: with SMTP id q6mr598503wrm.218.1580413717245; Thu, 30 Jan 2020 11:48:37 -0800 (PST) Original-Received: from betli.gmail.com (catv-178-48-82-41.catv.broadband.hu. [178.48.82.41]) by smtp.gmail.com with ESMTPSA id z25sm7492903wmf.14.2020.01.30.11.48.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Jan 2020 11:48:36 -0800 (PST) In-Reply-To: <871rrhkgkm.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 30 Jan 2020 01:07:05 +0200") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEUMBwgHAgMFAAGPjY7/ //80MDHq6eqJt3pKAAABr0lEQVQ4jX2UzZKDIAzHqR177q7TPbtx2HMr6guQcrbY9txZ0fd/hA0f onXazcEJ/CD8E4Js8/HS9mwjXtqeMRxHXJkakTEm4b4GPVQW8PU8ov4fQCqeThlF60MBWdo1IXzd 2nEEZE7CEAZLwI0N/gJAhTj7ESQAX4gPgO8lyI+cvgViSVPlNomAj2M9gW40eg7VWY3cATjUcyiO Z+i03cFruGLYoUR7VyU3HihdmCEVhoDN65FXkpbSxkomOzsTQN/gySaodGb9Gdi1oSRXP46gdBWh LcUKJNdeGCWac74GKakmne0aHCFvyqJPYLsCFAVlhRTvGdzMdLHqtgRyUulyXIAH7CYQ3AB0Nody JQhAkq/qtOnbjhxdzYDkXPxlH5y4WdUAeUcX1NVJ6GR7UQEYPGWoAnA36OQNn5lRRp38vHTAp9Br LoTmvlPPDoRCKzpjG1SXT89AaT5l456BamJuMcs+NIOMzJ/s5dI6yUVcrARlruwOebfdv6gunTn4 ww3+QjGBEn5suVyLHoSGvAqREuDLN+iqZ+VcFg+HBbsJUU9+FZthbez9T+bdb+kPv2Ls6ct3hTkA AAAASUVORK5CYII= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175454 Archived-At: > Could you please try to reproduce the issue using Eglot with the > following minimal patch. If it really fixes the bug then it > should be committed to Emacs 27 immediately, and more changes > could be added later. Unfortunately the minimal patch doesn't fix the issue. Case 1. When Eglot is started manually, then the recipe fails in an after-change-major-mode-hook where the buffer-file-name is non-nil for the temporary diff buffer. Case 2. With (add-to-list 'python-mode-hook 'eglot-ensure) the recipe fails in a post-command-hook, because eglot-ensure has this: (when buffer-file-name (add-hook 'post-command-hook #'maybe-connect 'append nil))))) And buffer-file-name is non-nil for the diff buffer during the execution of python-mode-hook. But during the execution of maybe-connect in the post-command-hook, the buffer-file-name is nil and that leads to an error.