From: Juri Linkov <juri@linkov.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 39994@debbugs.gnu.org
Subject: bug#39994: 27.0.90; Broken image-converter probe for imagemagick
Date: Mon, 16 Mar 2020 02:04:58 +0200 [thread overview]
Message-ID: <87v9n5cggl.fsf@mail.linkov.net> (raw)
In-Reply-To: <87wo7ma3n7.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 15 Mar 2020 02:00:12 +0200")
reopen 39994
tags 39994 - fixed
quit
>> We put imagemagick at the end because of the same reason we're
>> deprecating libmagick in Emacs -- imagemagick has had en enormous number
>> of exploitable bugs over the years. Running external programs mitigates
>> this slightly, but it should remain the last option.
>
> Right. I moved it up only because I was lazy to restart Emacs -
> currently customization of image-converter requires restarting Emacs,
> but it's not a big problem.
Sorry, I misremembered - actually it *is* a problem,
since handling customization is not yet implemented.
Here is a possible implementation:
diff --git a/lisp/image/image-converter.el b/lisp/image/image-converter.el
index 0488a13d41..4efae5c202 100644
--- a/lisp/image/image-converter.el
+++ b/lisp/image/image-converter.el
@@ -57,6 +57,10 @@ image-convert-p
;; Find an installed image converter.
(unless image-converter
(image-converter--find-converter))
+ ;; When image-converter was customized
+ (if (and image-converter (not image-converter-regexp))
+ (when-let ((formats (image-converter--probe image-converter)))
+ (setq image-converter-regexp (concat "\\." (regexp-opt formats) "\\'"))))
(and image-converter
(or (and (not data-p)
(string-match image-converter-regexp source))
next prev parent reply other threads:[~2020-03-16 0:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 0:09 bug#39994: 27.0.90; Broken image-converter probe for imagemagick Juri Linkov
2020-03-09 9:15 ` Lars Ingebrigtsen
2020-03-09 22:43 ` Juri Linkov
2020-03-14 12:02 ` Lars Ingebrigtsen
2020-03-15 0:00 ` Juri Linkov
2020-03-16 0:04 ` Juri Linkov [this message]
2020-03-29 23:16 ` Juri Linkov
2020-03-16 0:23 ` Juri Linkov
2020-08-02 7:56 ` Lars Ingebrigtsen
2020-08-02 23:31 ` Juri Linkov
2020-08-03 7:15 ` Lars Ingebrigtsen
2020-08-03 23:42 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9n5cggl.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=39994@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.