From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete Date: Sun, 05 Apr 2020 02:37:52 +0300 Organization: LINKOV.NET Message-ID: <87v9me960f.fsf@mail.linkov.net> References: <87a751uonw.fsf@mail.linkov.net> <9bab3a53-ec31-3300-132f-dc1e17ee0c53@yandex.ru> <875zfd9lzm.fsf@mail.linkov.net> <87mu8mieve.fsf@mail.linkov.net> <87k13pkxdl.fsf@mail.linkov.net> <207d4e30-aa59-b8eb-c39a-0957757f39eb@yandex.ru> <875zf6cy3w.fsf@mail.linkov.net> <9c39f788-29f1-5a68-c8f3-a4b08ae9ea3b@yandex.ru> <87lfo1dvcf.fsf@mail.linkov.net> <44cda45a-db93-f2c1-626d-9ace68cd6fd1@yandex.ru> <87y2rpqt28.fsf@mail.linkov.net> <874kuci4tx.fsf@mail.linkov.net> <786821a9-ceab-bbe8-b02a-69e77ddde426@yandex.ru> <878sjkjb8p.fsf@mail.linkov.net> <7d73cdd2-6af1-270c-1929-1bf618c304db@yandex.ru> <87tv26pzji.fsf@mail.linkov.net> <979c0191-48ce-f13f-361e-a03b3ff393a6@yandex.ru> <87a73t8rrl.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="36113"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , 34949@debbugs.gnu.org, Dmitry Gutov To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 05 01:59:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jKshC-0009JF-NC for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Apr 2020 01:59:26 +0200 Original-Received: from localhost ([::1]:43130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKshB-0008E4-Ct for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Apr 2020 19:59:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47201) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKsgp-000844-5t for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2020 19:59:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKsgo-0006Bu-3M for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2020 19:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33423) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jKsgn-0006Bo-Vk for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2020 19:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jKsgn-0001ER-U2 for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2020 19:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Apr 2020 23:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed fixed Original-Received: via spool by 34949-submit@debbugs.gnu.org id=B34949.15860447074583 (code B ref 34949); Sat, 04 Apr 2020 23:59:01 +0000 Original-Received: (at 34949) by debbugs.gnu.org; 4 Apr 2020 23:58:27 +0000 Original-Received: from localhost ([127.0.0.1]:44966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKsgF-0001Bq-0M for submit@debbugs.gnu.org; Sat, 04 Apr 2020 19:58:27 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:49599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKsgC-0001BH-PQ for 34949@debbugs.gnu.org; Sat, 04 Apr 2020 19:58:25 -0400 X-Originating-IP: 91.129.99.85 Original-Received: from mail.gandi.net (m91-129-99-85.cust.tele2.ee [91.129.99.85]) (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 0665620003; Sat, 4 Apr 2020 23:58:16 +0000 (UTC) In-Reply-To: (Philipp Stephani's message of "Fri, 3 Apr 2020 22:08:59 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178042 Archived-At: >> Many things were implemented under this request >> and more could be done on another round of improvements, >> but it would be too much for the same request, >> so I'm closing it now. > > I haven't followed this bug that closely, but it seems the initial > issue about the undocumented arguments and return values of > vc-deduced-fileset isn't addressed yet. At least on both master and > emacs-27 these topics are still not documented. Thanks for the report, I checked your initial request to see what remains to do: > The docstring of `vc-deduce-fileset' doesn't describe the OBSERVER parameter. OBSERVER was renamed to NOT-STATE-CHANGING a week ago in master and described in the docstring of `vc-deduce-fileset'. > It also doesn't explain the meaning of the return values > FILESET-ONLY-FILES, STATE, and CHECKOUT-MODEL. This is hard to explain because this is internal data, I even don't know where to begin. For example, here is some code from vc-next-action that uses data returned from vc-deduce-fileset: (not (eq model 'implicit)) (eq state 'up-to-date) Do you know what 'implicit' model means here and where to find all other possible model values? Also please help to find all possible states like 'up-to-date' here. I see more states used in vc-deduce-fileset like 'missing', 'ignored', 'needs-update', but where is a complete list?