From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#40919: 27.0.91; next-error-select-buffer does not always behave as documented Date: Wed, 20 May 2020 01:21:35 +0300 Organization: LINKOV.NET Message-ID: <87v9kr8t1s.fsf@mail.linkov.net> References: <53913bd9-2bdc-0f70-f7b4-744283e0512f@ieee.org> <87d07rmb6j.fsf@mail.linkov.net> <87zhau5bfw.fsf@mail.linkov.net> <66f63b16-307a-919c-1d25-60ff63f92ae6@ieee.org> <87bln8u3xq.fsf@mail.linkov.net> <851cd382-4b2e-447a-2212-919c8a4ce908@ieee.org> <87d07lykkd.fsf@mail.linkov.net> <83bln5rbah.fsf@gnu.org> <87zhaozlvo.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="120611"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 40919@debbugs.gnu.org, tspiteri@ieee.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 20 00:26:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jbAgd-000VGK-2i for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 May 2020 00:26:11 +0200 Original-Received: from localhost ([::1]:52772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbAgc-0004Ra-1y for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 May 2020 18:26:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbAgU-0004Q8-Tw for bug-gnu-emacs@gnu.org; Tue, 19 May 2020 18:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39806) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jbAgU-0001WU-KK for bug-gnu-emacs@gnu.org; Tue, 19 May 2020 18:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jbAgU-0003sW-GZ for bug-gnu-emacs@gnu.org; Tue, 19 May 2020 18:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 May 2020 22:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40919 X-GNU-PR-Package: emacs Original-Received: via spool by 40919-submit@debbugs.gnu.org id=B40919.158992713214872 (code B ref 40919); Tue, 19 May 2020 22:26:02 +0000 Original-Received: (at 40919) by debbugs.gnu.org; 19 May 2020 22:25:32 +0000 Original-Received: from localhost ([127.0.0.1]:51352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbAfz-0003rn-Qj for submit@debbugs.gnu.org; Tue, 19 May 2020 18:25:32 -0400 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:35503) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbAfx-0003rG-1S for 40919@debbugs.gnu.org; Tue, 19 May 2020 18:25:29 -0400 Original-Received: from mail.gandi.net (m91-129-97-200.cust.tele2.ee [91.129.97.200]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 97EAA200003; Tue, 19 May 2020 22:25:21 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Tue, 19 May 2020 04:48:51 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180619 Archived-At: >> Another variant would be >> to add an optional choice to the existing option that allows to restore >> the old behavior and doesn't affect the current behavior in any way. > > FWIW, I'd consider that more of a documentation change. > > More importantly, and certainly only for Emacs 28, Juri could you remind me > what we'll be losing by removing the case no. 2 from > next-error-find-buffer? It is used to handle such cases when navigating one next-error list visits a buffer that contains another next-error list - visiting such buffer should not switch the navigation, it should continue the initial navigation. But I'm not proud of the case no. 2, so you can drop it :) Or better move it to a separate function and provide this function as an option in next-error-find-buffer-function. > The ability to switch to an arbitrary Grep buffer and start using it with > 'M-x next-error'? E.g. if there are several of them. That's more of > a backward compatibility concern, right? Or do you have scenarios in > mind where this will really save on keystrokes? The ability to visit an arbitrary Grep buffer and use 'next-error' in it to switch navigation should always work as the most reliable and implicit way to switch navigation. This is the case no. 3 in next-error-find-buffer. > On another note, perhaps we could add a message to next-error-select-buffer > that would be shown if we suspect this command will not have the expected > result for the user. Or maybe ask the user using the minibuffer to resolve ambiguity.