* bug#41440: 26.3; 'replace' argument in function 'shell-command-on-region' is assumed to be always t for rectangle selection
@ 2020-05-21 18:53 Warren Lynn
[not found] ` <83d06v13h2.fsf@gnu.org>
0 siblings, 1 reply; 9+ messages in thread
From: Warren Lynn @ 2020-05-21 18:53 UTC (permalink / raw)
To: 41440
[-- Attachment #1: Type: text/plain, Size: 667 bytes --]
Hi:
I am gladly surprised to find out function
shell-command-on-region
is supposed to work on rectangle selection also (with
'region-noncontiguous-p' set to t), but then disappointed to find out the
feature does not work. It has two problems:
1. As this email title says, argument 'replace' is assumed to be t no
matter what.
2. Even if I really want to replace the original selection with the
shell-command output, it still does not work. An error will be thrown in
function "cua--insert-rectangle" due to some argument type mismatch.
This feature will be very useful to me (and hopefully others too) and I
hope somebody can fix the above.
Thanks a lot.
Warren
[-- Attachment #2: Type: text/html, Size: 895 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#41440: 26.3; 'replace' argument in function 'shell-command-on-region' is assumed to be always t for rectangle selection
[not found] ` <83d06v13h2.fsf@gnu.org>
@ 2020-05-23 22:53 ` Juri Linkov
2020-06-08 0:35 ` Juri Linkov
1 sibling, 0 replies; 9+ messages in thread
From: Juri Linkov @ 2020-05-23 22:53 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 41440, Warren Lynn
>> I am gladly surprised to find out function
>> shell-command-on-region
>> is supposed to work on rectangle selection also (with 'region-noncontiguous-p' set to t), but then
>> disappointed to find out the feature does not work. It has two problems:
>>
>> 1. As this email title says, argument 'replace' is assumed to be t no matter what.
>> 2. Even if I really want to replace the original selection with the shell-command output, it still does not work.
>> An error will be thrown in function "cua--insert-rectangle" due to some argument type mismatch.
>>
>> This feature will be very useful to me (and hopefully others too) and I hope somebody can fix the above.
>
> Juri, could you please look into this? In addition to the problem
> described in the bug report, the 'region-noncontiguous-p' argument is
> not mentioned in the doc string and not in the manual. I'd like to
> fix that for Emacs 27, please.
This is not a bug, it was implemented so in Emacs 25.
Or you'd like to fix only documentation for Emacs 27?
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#41440: 26.3; 'replace' argument in function 'shell-command-on-region' is assumed to be always t for rectangle selection
[not found] ` <83d06v13h2.fsf@gnu.org>
2020-05-23 22:53 ` Juri Linkov
@ 2020-06-08 0:35 ` Juri Linkov
2020-06-08 14:39 ` Eli Zaretskii
1 sibling, 1 reply; 9+ messages in thread
From: Juri Linkov @ 2020-06-08 0:35 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 41440, Warren Lynn
>> From: Warren Lynn <wrn.lynn@gmail.com>
>> Date: Thu, 21 May 2020 14:53:05 -0400
>>
>> I am gladly surprised to find out function
>> shell-command-on-region
>> is supposed to work on rectangle selection also (with 'region-noncontiguous-p' set to t), but then
>> disappointed to find out the feature does not work. It has two problems:
>>
>> 1. As this email title says, argument 'replace' is assumed to be t no matter what.
>> 2. Even if I really want to replace the original selection with the
>> shell-command output, it still does not work.
>> An error will be thrown in function "cua--insert-rectangle" due to some argument type mismatch.
>>
>> This feature will be very useful to me (and hopefully others too) and I hope somebody can fix the above.
>
> Juri, could you please look into this? In addition to the problem
> described in the bug report, the 'region-noncontiguous-p' argument is
> not mentioned in the doc string and not in the manual. I'd like to
> fix that for Emacs 27, please.
Here is the docstring fix for Emacs 27:
diff --git a/lisp/simple.el b/lisp/simple.el
index 6e69f86739..69c9b68427 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -3952,7 +3952,12 @@ shell-command-on-region
Optional seventh arg DISPLAY-ERROR-BUFFER, if non-nil, means to
display the error buffer if there were any errors. When called
-interactively, this is t."
+interactively, this is t.
+
+Non-nil REGION-NONCONTIGUOUS-P means that the region is composed of
+noncontiguous pieces. The most common example of this is a
+rectangular region, where the pieces are separated by newline
+characters."
(interactive (let (string)
(unless (mark)
(user-error "The mark is not set now, so there is no region"))
^ permalink raw reply related [flat|nested] 9+ messages in thread
* bug#41440: 26.3; 'replace' argument in function 'shell-command-on-region' is assumed to be always t for rectangle selection
2020-06-08 0:35 ` Juri Linkov
@ 2020-06-08 14:39 ` Eli Zaretskii
2020-06-08 23:35 ` Juri Linkov
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2020-06-08 14:39 UTC (permalink / raw)
To: Juri Linkov; +Cc: 41440, wrn.lynn
> From: Juri Linkov <juri@linkov.net>
> Cc: Warren Lynn <wrn.lynn@gmail.com>, 41440@debbugs.gnu.org
> Date: Mon, 08 Jun 2020 03:35:25 +0300
>
> > Juri, could you please look into this? In addition to the problem
> > described in the bug report, the 'region-noncontiguous-p' argument is
> > not mentioned in the doc string and not in the manual. I'd like to
> > fix that for Emacs 27, please.
>
> Here is the docstring fix for Emacs 27:
LGTM, thanks.
Are you also looking into the rest of the bug report?
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#41440: 26.3; 'replace' argument in function 'shell-command-on-region' is assumed to be always t for rectangle selection
2020-06-08 14:39 ` Eli Zaretskii
@ 2020-06-08 23:35 ` Juri Linkov
2020-06-09 14:26 ` Eli Zaretskii
0 siblings, 1 reply; 9+ messages in thread
From: Juri Linkov @ 2020-06-08 23:35 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 41440, wrn.lynn
>> > Juri, could you please look into this? In addition to the problem
>> > described in the bug report, the 'region-noncontiguous-p' argument is
>> > not mentioned in the doc string and not in the manual. I'd like to
>> > fix that for Emacs 27, please.
>>
>> Here is the docstring fix for Emacs 27:
>
> LGTM, thanks.
Pushed docstring fix to emacs-27.
> Are you also looking into the rest of the bug report?
The first part of the original report asks for a new feature,
now I implemented it in master in commit 3b93549597.
The second part reports a bug, but I can't reproduce it.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#41440: 26.3; 'replace' argument in function 'shell-command-on-region' is assumed to be always t for rectangle selection
2020-06-08 23:35 ` Juri Linkov
@ 2020-06-09 14:26 ` Eli Zaretskii
2020-06-09 23:03 ` Juri Linkov
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2020-06-09 14:26 UTC (permalink / raw)
To: Juri Linkov; +Cc: 41440, wrn.lynn
> From: Juri Linkov <juri@linkov.net>
> Cc: wrn.lynn@gmail.com, 41440@debbugs.gnu.org
> Date: Tue, 09 Jun 2020 02:35:53 +0300
>
> Pushed docstring fix to emacs-27.
>
> > Are you also looking into the rest of the bug report?
>
> The first part of the original report asks for a new feature,
> now I implemented it in master in commit 3b93549597.
>
> The second part reports a bug, but I can't reproduce it.
OK, thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#41440: 26.3; 'replace' argument in function 'shell-command-on-region' is assumed to be always t for rectangle selection
2020-06-09 14:26 ` Eli Zaretskii
@ 2020-06-09 23:03 ` Juri Linkov
2020-08-24 0:36 ` Stefan Kangas
0 siblings, 1 reply; 9+ messages in thread
From: Juri Linkov @ 2020-06-09 23:03 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 41440, wrn.lynn
>> Pushed docstring fix to emacs-27.
>>
>> > Are you also looking into the rest of the bug report?
>>
>> The first part of the original report asks for a new feature,
>> now I implemented it in master in commit 3b93549597.
>>
>> The second part reports a bug, but I can't reproduce it.
>
> OK, thanks.
Actually, I found where the bug was, and pushed the fix to emacs-27
in the commit 22f4fba8a9.
Now we have to wait when Warren will have time to confirm
if everything is alright.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#41440: 26.3; 'replace' argument in function 'shell-command-on-region' is assumed to be always t for rectangle selection
2020-06-09 23:03 ` Juri Linkov
@ 2020-08-24 0:36 ` Stefan Kangas
2020-10-01 3:13 ` Lars Ingebrigtsen
0 siblings, 1 reply; 9+ messages in thread
From: Stefan Kangas @ 2020-08-24 0:36 UTC (permalink / raw)
To: Juri Linkov; +Cc: 41440, wrn.lynn
Juri Linkov <juri@linkov.net> writes:
>>> Pushed docstring fix to emacs-27.
>>>
>>> > Are you also looking into the rest of the bug report?
>>>
>>> The first part of the original report asks for a new feature,
>>> now I implemented it in master in commit 3b93549597.
>>>
>>> The second part reports a bug, but I can't reproduce it.
>>
>> OK, thanks.
>
> Actually, I found where the bug was, and pushed the fix to emacs-27
> in the commit 22f4fba8a9.
>
> Now we have to wait when Warren will have time to confirm
> if everything is alright.
Warren, did you have time to test if Juri's fix solved the problem?
If I don't hear back from you within a couple of weeks, I'll just
assume this has been fixed and close this bug. Thanks.
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#41440: 26.3; 'replace' argument in function 'shell-command-on-region' is assumed to be always t for rectangle selection
2020-08-24 0:36 ` Stefan Kangas
@ 2020-10-01 3:13 ` Lars Ingebrigtsen
0 siblings, 0 replies; 9+ messages in thread
From: Lars Ingebrigtsen @ 2020-10-01 3:13 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 41440, Juri Linkov, wrn.lynn
Stefan Kangas <stefan@marxist.se> writes:
>> Now we have to wait when Warren will have time to confirm
>> if everything is alright.
>
> Warren, did you have time to test if Juri's fix solved the problem?
>
> If I don't hear back from you within a couple of weeks, I'll just
> assume this has been fixed and close this bug. Thanks.
This was five weeks ago, so I'm now closing this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-10-01 3:13 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-21 18:53 bug#41440: 26.3; 'replace' argument in function 'shell-command-on-region' is assumed to be always t for rectangle selection Warren Lynn
[not found] ` <83d06v13h2.fsf@gnu.org>
2020-05-23 22:53 ` Juri Linkov
2020-06-08 0:35 ` Juri Linkov
2020-06-08 14:39 ` Eli Zaretskii
2020-06-08 23:35 ` Juri Linkov
2020-06-09 14:26 ` Eli Zaretskii
2020-06-09 23:03 ` Juri Linkov
2020-08-24 0:36 ` Stefan Kangas
2020-10-01 3:13 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.