all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Cc: 42334@debbugs.gnu.org
Subject: bug#42334: 28.0.50; gnus-thread-sort-functions vs. loose threads
Date: Sun, 19 Jul 2020 02:13:38 +0200	[thread overview]
Message-ID: <87v9ikjr9p.fsf@gnus.org> (raw)
In-Reply-To: <87blkkc28b.fsf@gmail.com> ("Kévin Le Gouguec"'s message of "Sun, 12 Jul 2020 15:05:56 +0200")

Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:

> Is this indeed a bug, or am I missing something?

It's an artefact of the way Gnus does these things.  This is the code:

	   (gnus-sort-gathered-threads
	    (funcall gnus-summary-thread-gathering-function
		     (gnus-sort-threads
		      (gnus-cut-threads (gnus-make-threads)))))

First we sort the threads, then we gather loose threads, and then we
sort the loose threads individually.

So there's no way to do sorting (globally) after the threads have been
gathered.

Changing the order all this happens in would be possible, but it would
change how this all behaves.  So to fix this, we'd have to add yet
another sort -- on the outside, after doing all this, and this would
require a new set of sorting predicates, because the structure of a
gathered thread is different than the structure of a normal thread.

So you couldn't use gnus-thread-sort-by-most-recent-date and the like
for that top-level sorting thing.

So I don't think adding this functionality is worth it, although it's
something that's been requested a few times, and I'm closing this bug
report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2020-07-19  0:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-12 13:05 bug#42334: 28.0.50; gnus-thread-sort-functions vs. loose threads Kévin Le Gouguec
2020-07-19  0:13 ` Lars Ingebrigtsen [this message]
2020-07-19  9:42   ` Kévin Le Gouguec
2020-07-19 13:09     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9ikjr9p.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=42334@debbugs.gnu.org \
    --cc=kevin.legouguec@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.