all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: juanjose.garcia.ripoll@csic.es,
	Lars Ingebrigtsen <larsi@gnus.org>,
	rpluim@gmail.com, 40248@debbugs.gnu.org
Subject: bug#40248: 27.0.90; Failure open .authinfo.gpg from Gnus
Date: Thu, 23 Jul 2020 03:20:44 +0300	[thread overview]
Message-ID: <87v9ifdqub.fsf@mail.linkov.net> (raw)
In-Reply-To: <83v9ijh8ez.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 19 Jul 2020 17:43:48 +0300")

>> That sounds like a very useful thing to have.  How do you make vc-mode
>> (etc) show both dates?
>
> You don't need to tell VC anything, just say in your ~/.gitconfig
>
>   [format]
> 	  pretty = fuller

This setting breaks vc-git-log-view-mode: typing 'D' in the log buffer
with "CommitDate" throws the error:

  fatal: bad revision 'Date'

This is because it searches for the commit number and finds "CommitDate"
as in this example:

  commit 365e01cc9f64ce6ca947ccfd8612d60763280a37
  CommitDate: 2020-01-01 00:59:52 +0000

The problem is that 'vc-git-log-view-mode' sets 'log-view-message-re'
to this regexp:

  "^commit *\\([0-9a-z]+\\)"

where "\\([0-9a-z]+\\)" matches "Date" in "CommitDate".

This patch fixes it, but I'm not sure if this is the correct regexp
for git commits:

diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
index 9b8151705f..2220a33188 100644
--- a/lisp/vc/vc-git.el
+++ b/lisp/vc/vc-git.el
@@ -1241,7 +1241,7 @@ vc-git-log-view-mode
   (set (make-local-variable 'log-view-message-re)
        (if (not (memq vc-log-view-type '(long log-search with-diff)))
 	   (cadr vc-git-root-log-format)
-	 "^commit *\\([0-9a-z]+\\)"))
+	 "^commit +\\([0-9a-z]+\\)"))
   ;; Allow expanding short log entries.
   (when (memq vc-log-view-type '(short log-outgoing log-incoming mergebase))
     (setq truncate-lines t)






  parent reply	other threads:[~2020-07-23  0:20 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26 23:07 bug#40248: 27.0.90; Failure open .authinfo.gpg from Gnus Juan José García Ripoll
2020-03-27  8:18 ` Eli Zaretskii
2020-03-27 13:34   ` Eli Zaretskii
2020-03-27 16:21     ` Juan José García-Ripoll
2020-03-28  7:55       ` Eli Zaretskii
2020-03-28  8:40         ` Lars Ingebrigtsen
2020-03-28  9:17           ` Eli Zaretskii
2020-03-29  7:45             ` Lars Ingebrigtsen
2020-03-29 13:49               ` Eli Zaretskii
2020-03-31  9:20                 ` Robert Pluim
2020-03-31  9:53                   ` Andreas Schwab
2020-03-31 10:16                     ` Robert Pluim
2020-03-31 10:31                       ` Andreas Schwab
2020-03-31 11:09                         ` Robert Pluim
2020-03-31 16:13                           ` Robert Pluim
2020-03-31 17:59                             ` Eli Zaretskii
2020-03-31 19:53                               ` Robert Pluim
2020-04-02 11:10                             ` Lars Ingebrigtsen
2020-04-02 12:48                               ` Robert Pluim
2020-04-03 11:52                                 ` Lars Ingebrigtsen
2020-04-03 12:50                                   ` Robert Pluim
2020-03-28 14:03         ` Juan Jose Garcia Ripoll
2020-03-28 14:36           ` Eli Zaretskii
2020-03-29  7:48         ` Lars Ingebrigtsen
2020-03-29 13:52           ` Eli Zaretskii
2020-03-30  9:37             ` Robert Pluim
2020-03-30 13:10               ` Eli Zaretskii
2020-03-30 14:10                 ` Robert Pluim
2020-03-30 14:33                   ` Eli Zaretskii
2020-04-02 11:11                     ` Lars Ingebrigtsen
2020-04-03 11:31                       ` Eli Zaretskii
2020-04-03 11:43                         ` Robert Pluim
2020-07-19  2:45                           ` Lars Ingebrigtsen
2020-07-19 14:23                             ` Eli Zaretskii
2020-07-19 14:29                               ` Lars Ingebrigtsen
2020-07-19 14:43                                 ` Eli Zaretskii
2020-07-19 14:45                                   ` Lars Ingebrigtsen
2020-07-23  0:20                                   ` Juri Linkov [this message]
2020-07-23 13:36                                     ` Dmitry Gutov
2020-07-20  8:42                               ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9ifdqub.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=40248@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=juanjose.garcia.ripoll@csic.es \
    --cc=larsi@gnus.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.