From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#39293: [PATCH] Base bookmark-bmenu-mode on 'tabulated-list-mode' Date: Tue, 18 Aug 2020 17:24:04 +0200 Message-ID: <87v9hght9n.fsf@gnus.org> References: <87lfpu9ag8.fsf@marxist.se> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32131"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39293@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 18 17:47:43 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k83pv-0008DK-3X for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 Aug 2020 17:47:43 +0200 Original-Received: from localhost ([::1]:44118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k83pu-0001E9-4q for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 Aug 2020 11:47:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k83Ty-00070V-Q3 for bug-gnu-emacs@gnu.org; Tue, 18 Aug 2020 11:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53395) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k83Ty-0000xf-BY for bug-gnu-emacs@gnu.org; Tue, 18 Aug 2020 11:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k83Ty-00023x-8h for bug-gnu-emacs@gnu.org; Tue, 18 Aug 2020 11:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Aug 2020 15:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39293-submit@debbugs.gnu.org id=B39293.15977642627882 (code B ref 39293); Tue, 18 Aug 2020 15:25:02 +0000 Original-Received: (at 39293) by debbugs.gnu.org; 18 Aug 2020 15:24:22 +0000 Original-Received: from localhost ([127.0.0.1]:36708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k83TK-000234-4P for submit@debbugs.gnu.org; Tue, 18 Aug 2020 11:24:22 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:33806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k83TH-00022p-BS for 39293@debbugs.gnu.org; Tue, 18 Aug 2020 11:24:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8CyckvYuKYXIiVwqE7yr5X2z/PACqSxISTYNF3pi5vQ=; b=NkoOV3RN4JZzoLvusdyaAVRDwS tfbckvBFIy2ADArHE2zUegruZunEyF3cOda1k4e2xgkxCLXxBZBDV58NeE/WixxpV/4FUqjJ6EVVO TvPN+daNQnMFHiwsoJX8j1JdtVzyeUgLR/QW8KjiJoGBr96cvZOZx7bIaMH4JOUUGvQY=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k83T4-0008HU-Ea; Tue, 18 Aug 2020 17:24:12 +0200 X-Now-Playing: The Wolfgang Press's _The Legendary Wolfgang Press and Other Tall Stories_: "Heart of Stone" In-Reply-To: <87lfpu9ag8.fsf@marxist.se> (Stefan Kangas's message of "Sun, 26 Jan 2020 04:13:27 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185509 Archived-At: Stefan Kangas writes: > The attached patch changes bookmark-bmenu-mode to be based on > tabulated-list-mode instead of special-mode. > > This allows us to simplify the code in several cases. In addition, we > get many features for free, such as sorting columns by clicking on the > column headers, changing size of columns. In the future, this will > obviously include any new feature added to 'tabulated-list-mode'. Makes sense to me. There was an objection about packages that extend bookmark.el would no longer work... but I don't think that's an objection we have to heed. As far as I can see, the public interface isn't changed (i.e., the commands are still the same), which is the only this we try to keep compatible. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no