From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: A faster derived-mode-p Date: Mon, 15 Feb 2021 03:56:29 +0100 Message-ID: <87v9au82ea.fsf@gnus.org> References: <87k0ra9z7w.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7695"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 15 03:57:26 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBU4k-0001uE-9G for ged-emacs-devel@m.gmane-mx.org; Mon, 15 Feb 2021 03:57:26 +0100 Original-Received: from localhost ([::1]:52454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBU4j-0005Hx-CW for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Feb 2021 21:57:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34736) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBU3x-0004q9-UO for emacs-devel@gnu.org; Sun, 14 Feb 2021 21:56:37 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:55708) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBU3w-0006qs-7v for emacs-devel@gnu.org; Sun, 14 Feb 2021 21:56:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+b1sq00i6DamaUtB1bBDDj3U0knLJZlgsIaq06SZDWs=; b=j1lxwlbI+k7F59r2TI8maClvP/ y2+ahZZm/RofYctWLMuw7nnOrJTGZK4zvcDIqBGCkJM3HQUGfrZU7ImTl5KD3w/5e6G83kG0c59jO tnHYdlybZxP5Vqa10gTYGC/8r+fAomEbAcpo4YuRMSXvlgnSIYx3X1k9jvnYyv6zLqI4=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBU3r-0000Us-4o; Mon, 15 Feb 2021 03:56:33 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEXo2Md/f3DnS2L/ //9XflpNAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+UCDwIsLKCTsIQAAAFfSURBVCjPZdKxbsIwEAbg P1ZA1JOpoGo3q4Iq8lOECpZOGZoBpqgTzVMYxFAx8wAGUcm5p+xdEtqhpwz55Pt9jhUgqakA1wQJ yrKmRpAygJrIC9RZEFwQaMEWsAK3A/xWYSSwiQC+BXGb3bZdGDhBjUxw5xLoUHsnGIUOmueoeDwz 3oKSOSQZvAYIXJZA3ZDZHZTP+ZWfjDOMCMWb6zYjGCn/whmE/AtK63287HjrnIc4TQ1nHgQImog/ 4b3ooTljTIfo+GzqKhl6Ds7zikDTJTq+nftZi/2F0Gc0hSjQ1x6aMRS46FtMl4zMWT+QzLhyFB35 OUNNKqJIBAGufPHUw7SI5L9l6LkDVwN1atvcfwwPW+qrwXTR7cZrDSbFx9Ha3SE1/gk4VcNHrFam yBmzKjVmuUqKxRqY58vU5AmKnGEF4yQ1gzVf4qrsixE/byihbF1u2kGbsvt3/vDbVf4ADoOdtQUT 9loAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMDItMTVUMDI6NDQ6NDQrMDA6MDA7lF7MAAAAJXRF WHRkYXRlOm1vZGlmeQAyMDIxLTAyLTE1VDAyOjQ0OjQ0KzAwOjAwSsnmcAAAAABJRU5ErkJggg== X-Now-Playing: Ny Anjarasoa's _Alefa Madagascar_: "Mahonena" In-Reply-To: (Stefan Monnier's message of "Sun, 14 Feb 2021 18:51:04 -0500") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:264826 Archived-At: Stefan Monnier writes: > Here's my suggestion: > Instead of trying to speed up those 10K predicates we're going to have > to evaluate, we could try to take advantage of the fact that there > should be a lot of redundancy there. > > So we could do something like: > > (let ((cmds (make-hash-table :test #'equal))) > (mapatom (lambda (sym) > (when (commandp sym) > (push sym (gethash (command-predicate sym) cmds))))) > (let (active-cmds) > (maphash (lambda (pred syms) > (when (funcall pred) > (cl-callf nconc active-cmds syms))) > cmds) > active-cmds)) Hm, right... As Dmitry showed, my worries about the inefficiency of derived-mode-p seem exaggerated, but if it turns out to be a problem (or we have more complex predicates), then doing something like this seems promising. However, the vast, vast number of the predicates basically devolve to this (on the happy path): (or (derived-mode-p 'foo-mode) (memq 'foo-mode minor-modes) (memq 'foo-mode global-minor-modes)) The derived-mode-p is fast, `minor-modes' is typically less than four elements, and the same with `global-minor-modes'. I'm not sure that it's likely that looping over the symbols and entering the predicates into a hash table has much scope for improving the speed much -- it'll already be quite speedy. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no