From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: A faster derived-mode-p
Date: Mon, 15 Feb 2021 03:56:29 +0100 [thread overview]
Message-ID: <87v9au82ea.fsf@gnus.org> (raw)
In-Reply-To: <jwvblcm43ws.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 14 Feb 2021 18:51:04 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Here's my suggestion:
> Instead of trying to speed up those 10K predicates we're going to have
> to evaluate, we could try to take advantage of the fact that there
> should be a lot of redundancy there.
>
> So we could do something like:
>
> (let ((cmds (make-hash-table :test #'equal)))
> (mapatom (lambda (sym)
> (when (commandp sym)
> (push sym (gethash (command-predicate sym) cmds)))))
> (let (active-cmds)
> (maphash (lambda (pred syms)
> (when (funcall pred)
> (cl-callf nconc active-cmds syms)))
> cmds)
> active-cmds))
Hm, right... As Dmitry showed, my worries about the inefficiency of
derived-mode-p seem exaggerated, but if it turns out to be a problem (or
we have more complex predicates), then doing something like this seems
promising.
However, the vast, vast number of the predicates basically devolve to
this (on the happy path):
(or (derived-mode-p 'foo-mode)
(memq 'foo-mode minor-modes)
(memq 'foo-mode global-minor-modes))
The derived-mode-p is fast, `minor-modes' is typically less than four
elements, and the same with `global-minor-modes'. I'm not sure that
it's likely that looping over the symbols and entering the predicates
into a hash table has much scope for improving the speed much -- it'll
already be quite speedy.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2021-02-15 2:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-14 20:22 A faster derived-mode-p Lars Ingebrigtsen
2021-02-14 22:25 ` Dmitry Gutov
2021-02-14 22:45 ` Basil L. Contovounesios
2021-02-14 23:03 ` Óscar Fuentes
2021-02-15 2:34 ` Dmitry Gutov
2021-02-15 2:47 ` Lars Ingebrigtsen
2021-02-14 23:51 ` Stefan Monnier
2021-02-15 2:56 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9au82ea.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.