From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height Date: Thu, 18 Mar 2021 21:00:41 +0200 Organization: LINKOV.NET Message-ID: <87v99owali.fsf@mail.linkov.net> References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> <877dm4o6fj.fsf@tcd.ie> <83zgz0fqcs.fsf@gnu.org> <87mtv0lc53.fsf@tcd.ie> <87y2eko0js.fsf@mail.linkov.net> <83mtv0fgbu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13906"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: contovob@tcd.ie, 47234@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 18 20:03:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMxvJ-0003WX-S4 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Mar 2021 20:03:09 +0100 Original-Received: from localhost ([::1]:38418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMxvI-0003xz-Ty for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Mar 2021 15:03:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMxuE-0003RL-Gw for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 15:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36546) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lMxuE-00050I-9Y for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 15:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lMxuE-0002RF-6g for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 15:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Mar 2021 19:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47234 X-GNU-PR-Package: emacs Original-Received: via spool by 47234-submit@debbugs.gnu.org id=B47234.16160941099329 (code B ref 47234); Thu, 18 Mar 2021 19:02:02 +0000 Original-Received: (at 47234) by debbugs.gnu.org; 18 Mar 2021 19:01:49 +0000 Original-Received: from localhost ([127.0.0.1]:48084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMxu1-0002QO-3d for submit@debbugs.gnu.org; Thu, 18 Mar 2021 15:01:49 -0400 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:53501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMxtx-0002Px-4n for 47234@debbugs.gnu.org; Thu, 18 Mar 2021 15:01:45 -0400 Original-Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 9D40B200007; Thu, 18 Mar 2021 19:01:37 +0000 (UTC) In-Reply-To: <83mtv0fgbu.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 Mar 2021 20:48:53 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202643 Archived-At: >> I agree with Martin that `tab-bar-height' should return a meaningful value >> on --without-x builds too. > > How do you propose to do that? The design and implementation of the > code in tab-bar-height was stolen from the tool bar, and that was > written for GUI frames. The text-mode tab bar has an entirely > different design and implementation, similar to the text-mode menu > bar. There's almost nothing in common between these two. Then the fix is not straightforward, indeed. >> Please note this should be fixed on the release branch in Emacs 27.2 >> because the change in commit 6c5ddf0e0b was recently made in emacs-27. > > Why does it have to be done in Emacs 27.2? > > Please be aware that Emacs 27.2 is all but released at this point. Martin said that the commit 6c5ddf0e0b added recently in emacs-27 should be reverted from Emacs 27.2. >> I wonder why only tab-bar-height was added to frame-inner-height, >> why not menu-bar-height as well? Moreover, such function as >> menu-bar-height doesn't exist at all. Why only tab-bar-height is needed? > > Maybe tab-bar-height is not needed in this case, either. We could > instead modify the code that attempts to call it. Grepping shows that the only code that calls frame-inner-height is mouse-drag-frame-resize.