From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063) Date: Fri, 26 Mar 2021 23:11:58 +0100 Message-ID: <87v99d7efl.fsf@gnus.org> References: <20210313133546.6042.78482@vcs0.savannah.gnu.org> <20210313133547.AA06C20B2E@vcs0.savannah.gnu.org> <877dma1yfv.fsf@tcd.ie> <87sg4ygmd9.fsf@gmx.de> <87zgz5uc0k.fsf@tcd.ie> <87tup0kxeg.fsf@tcd.ie> <878s6ba96u.fsf@gnus.org> <87mtuqaqa2.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12508"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Michael Albinus , Stefan Monnier , emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 26 23:12:55 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPuhL-0003Ai-4d for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Mar 2021 23:12:55 +0100 Original-Received: from localhost ([::1]:44060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPuhK-0001ea-3b for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Mar 2021 18:12:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPugZ-000185-FR for emacs-devel@gnu.org; Fri, 26 Mar 2021 18:12:07 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:56124) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPugX-00082x-Qo for emacs-devel@gnu.org; Fri, 26 Mar 2021 18:12:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MJSABqdtanpfPIWMUh7A6oa0eZGEmVGxKCVm1vy+mIg=; b=qX2OMuZgYBL1ybiyBNo6J7ne8C mVou7kDx3zdfyIFgQNMQ7UF2t34U1vrBc//efuSlYN+BGU+Ob+GL1pkBHy9mww3nCuWZrx29zoSMl 6vD50df19LA2wzM4WaAY8RSrRFDKfM89IQzCc5nKFiWRapGZMy5GVXT7fXibAmEjTo4I=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPugS-0006j7-1A; Fri, 26 Mar 2021 23:12:02 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEUoFB5VNjS8dIK7 qqP39fS8RTfcsUX///99SiQ5AAAAAWJLR0QHFmGI6wAAAAd0SU1FB+UDGhYDFjUL1OoAAAGlSURB VDjLnZPPbsIwDMaTSdztSOXeVN2dpuMBtj4AAbnnMZa8/yPMdv/QVuUySyDhX/x9thOM2Q1E8yKs +X9sRGcpCy+AQ9gHpQfYAxacOy3yMAE+XZ1KOYCaAnwWOt8gvp0qNYNFk1g1pXOfbXnarMS6sqxc UMU1KBAr8q5RFzt7WyIsPCGfXYOCiG6RAegWcNoHCrjyJ8JidVyHhWQltsulaLWCYL0rJLB0o2iK 9c7Umw2ixV2gUi/B+tIEpLECp0uzqKCqbxMYNwU63zVwtlZgBx/+trGg25mBFw+cxzaHeGCQ3umn JlaetXjlUpHqfgY41jDIWdb4BJxN2tV5GCNOUtZgzhfe1VnHSBEEyM3ZPudsiKVYq/+4SMXxLhch 4Lvofx9tyDlJt8csAAXcuU6BZhgAuyowh5yDz0mV+nzHQVwO9jlRjVLAgBuNFPx7f9d3FYeBuc3E zUKJ7hhX/x3xNPz+iirB8LjGu3mIh3XoeMBlcDcMQmjDOtqu676C6ebQ7PxrAZrGB78BejQMYKwa QBOadqpQj5VUCH7fowvdM9/9AQYijYD1OMnmAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTAzLTI2 VDIyOjAzOjIyKzAwOjAwgPChCQAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wMy0yNlQyMjowMzoy MiswMDowMPGtGbUAAAAASUVORK5CYII= X-Now-Playing: Earwig's _Past_: "Both Of Us Screaming" In-Reply-To: <87mtuqaqa2.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 26 Mar 2021 15:27:49 +0000") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267087 Archived-At: "Basil L. Contovounesios" writes: > e w w - TAB C-a C-k RET > bench-pred-expensive 1.080096 30 0.413564 > bench-pred-expensive 1.078444 30 0.413685 > bench-pred-expensive 1.077938 30 0.414732 > bench-pred-none 1.003878 30 0.416143 > bench-pred-none 0.987872 30 0.413814 > bench-pred-none 0.991742 30 0.416257 > bench-pred-old 0.889184 25 0.343545 > bench-pred-old 0.889369 25 0.344027 > bench-pred-old 0.885496 25 0.343227 > bench-pred-new 0.901361 25 0.345625 > bench-pred-new 0.887233 25 0.344885 > bench-pred-new 0.889201 25 0.344515 > > Where bench-pred-new extends bench-pred-old with the suggested > condition-case-unless-debug in the "tight" loop. Hm... I'm not quite sure I understand these benchmarks. There are no completion predicates for any eww-* symbols, I think? So there shouldn't be any differences here at all, if I read the patch correctly. What I was wondering was -- if (at some point in the future) we have, say, 2K symbols with a completion predicate -- would putting that condition-case inside the loop make things slower or not? My gut feeling says that it's probably not an issue (so we should just go ahead and do it), but it'd be nice to know... I just did a simple comparison of (defun foo1 () (+ 1 2)) (defun foo2 () (condition-case () (+ 1 2) (error nil))) and the latter is 25% slower... But: (benchmark-run 10000000 (foo2)) => (0.42124799 0 0.0) So ten million condition-cases doesn't take a lot of time, so it's fine to have it in the completion loop here. > Of course this use case isn't as critical/irreversible as > post-command-hook or process filters/sentinels, but the general notion > is similar: it would be nice if code errors didn't bork M-x completion. Yup; true. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no