From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#35468: [PATCH] Refactor draw_glyph_string on X and w32 Date: Wed, 12 May 2021 16:43:17 +0200 Message-ID: <87v97ohv22.fsf@gnus.org> References: <877ebeor2d.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1186"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 35468@debbugs.gnu.org To: Alex Gramiak Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 12 16:44:56 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgq6Z-0000Au-LY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 May 2021 16:44:55 +0200 Original-Received: from localhost ([::1]:47290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgq6Y-0006l8-Le for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 May 2021 10:44:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgq5i-0005a7-BP for bug-gnu-emacs@gnu.org; Wed, 12 May 2021 10:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56709) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lgq5i-0004Dm-3M for bug-gnu-emacs@gnu.org; Wed, 12 May 2021 10:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lgq5i-00023U-0G for bug-gnu-emacs@gnu.org; Wed, 12 May 2021 10:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 May 2021 14:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35468 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35468-submit@debbugs.gnu.org id=B35468.16208306107846 (code B ref 35468); Wed, 12 May 2021 14:44:01 +0000 Original-Received: (at 35468) by debbugs.gnu.org; 12 May 2021 14:43:30 +0000 Original-Received: from localhost ([127.0.0.1]:40022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgq5C-00022T-2Q for submit@debbugs.gnu.org; Wed, 12 May 2021 10:43:30 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:59354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgq5A-00022C-BF for 35468@debbugs.gnu.org; Wed, 12 May 2021 10:43:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yltM+wKe68Qn1UagIHOk2hGC6ubYNPp4OnLgOm5H+Tw=; b=RWxd6nxggVZEL9/ZdM0aF/yU5J YePwyhYTmjbhz4j8H1D2/7/lKLZTFBPjCFy46GHyFS4U293s6mY7V3vGtIOi4SIIIgEeJPpeSyRaa O1Cv8khRnkH06FugWp/zuqC16mdfXI25Yad2oJnrPG0YdAmtnomdbGaNnjq1ch/dvzy8=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgq51-0005j7-F2; Wed, 12 May 2021 16:43:21 +0200 X-Now-Playing: Fire!'s _Defeat_: "Defeat (only further apart)" In-Reply-To: <877ebeor2d.fsf@gmail.com> (Alex Gramiak's message of "Sat, 27 Apr 2019 19:29:30 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206331 Archived-At: Alex Gramiak writes: > This merges x_draw_glyph_string and w32_draw_glyph_string together to > remove duplicated code. > > I wanted to do it for NS as well, but it seems just a bit too different > to make it easily work. Skimming this thread, it seems like the consensus was that this patch is an improvement, but that it'd be nice to cover NS as well. But it seems like the discussion mostly dissipated without reaching any conclusion. Alex, have you done any further work on this, or is this abandoned? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no