bug#48379: 27.2; ispell-init-process may be called recursively during sit-for

bug#48379: 27.2; ispell-init-process may be called recursively during sit-for

[miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 1751 bytes --]


In ispell-init-process, sit-for can accept process output, which may in
turn call ispell-init-process again, recursively. If needed, I can post
a short reproducer.

This recursive call results in the following sequence of events:

    (ispell-kill-ispell t)
    (ispell-kill-ispell t)
    (setq ispell-process (ispell-start-process))
    (setq ispell-process (ispell-start-process))

where the middle two calls happen recursively from within sit-for. As
you can see, this creates one extra useless ispell process.

The following simple patch fixes this by moving the killing of the
process closer to starting of the new process without sit-for in the
middle

diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el
index 4dbc7640bc..80ddb4861f 100644
--- a/lisp/textmodes/ispell.el
+++ b/lisp/textmodes/ispell.el
@@ -2865,8 +2865,6 @@ ispell-init-process
 	     (or (or ispell-local-pdict ispell-personal-dictionary)
 		 (equal ispell-process-directory default-directory)))
 	(setq ispell-filter nil ispell-filter-continue nil)
-      ;; may need to restart to select new personal dictionary.
-      (ispell-kill-ispell t)
       (let ((reporter
              (make-progress-reporter
               (format "Starting new Ispell process %s with %s dictionary..."
@@ -2874,6 +2872,8 @@ ispell-init-process
 	              (or ispell-local-dictionary ispell-dictionary
                           "default")))))
         (sit-for 0)
+        ;; May need to restart to select new personal dictionary.
+        (ispell-kill-ispell t)
         (setq ispell-library-directory (ispell-check-version)
               ;; Assign a non-nil value to ispell-process-directory
               ;; before calling ispell-start-process, since that

Best regards.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

bug#48379: 27.2; ispell-init-process may be called recursively during sit-for

[Lars Ingebrigtsen]

miha@kamnitnik.top writes:

> In ispell-init-process, sit-for can accept process output, which may in
> turn call ispell-init-process again, recursively. If needed, I can post
> a short reproducer.

Yes, a reproducer would be nice to have here.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#48379: 27.2; ispell-init-process may be called recursively during sit-for

[miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> miha@kamnitnik.top writes:
>
>> In ispell-init-process, sit-for can accept process output, which may in
>> turn call ispell-init-process again, recursively. If needed, I can post
>> a short reproducer.
>
> Yes, a reproducer would be nice to have here.

My original problem was kind of complex:
Install magit and guess-language.el,
change ispell default dictionary to a non-English language,
hook flyspell-mode and guess-language to text-mode,
each M-x magit-commit-create would leave a spurious aspell process.

So as I was coming up with a shorter reproducer, I found out that the
problem was an idle timer from guess-language, accidentally hijacking
itself into ispell's sit-for. I no longer believe this problem to be
ispell's and will send a report to guess-language.

> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

Best regards.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

bug#48379: 27.2; ispell-init-process may be called recursively during sit-for

[Lars Ingebrigtsen]

<miha@kamnitnik.top> writes:

> So as I was coming up with a shorter reproducer, I found out that the
> problem was an idle timer from guess-language, accidentally hijacking
> itself into ispell's sit-for. I no longer believe this problem to be
> ispell's and will send a report to guess-language.

Ah, I see.  :-)  Thanks for checking; I'm closing this bug report here,
then.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no