From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#3909: 23.1.50; Drag drop events in command history? Date: Sun, 18 Jul 2021 21:21:43 +0200 Message-ID: <87v957mnqw.fsf_-_@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25698"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Glenn Morris , 3909@debbugs.gnu.org, Stefan Monnier , 12915@debbugs.gnu.org To: Dani Moncayo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 18 21:22:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5CMh-0006Rp-Eo for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Jul 2021 21:22:15 +0200 Original-Received: from localhost ([::1]:45826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5CMf-0001Q8-Br for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Jul 2021 15:22:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5CMV-0001PD-3k for bug-gnu-emacs@gnu.org; Sun, 18 Jul 2021 15:22:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45842) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5CMU-0003w4-Sy for bug-gnu-emacs@gnu.org; Sun, 18 Jul 2021 15:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m5CMU-0002ER-OL for bug-gnu-emacs@gnu.org; Sun, 18 Jul 2021 15:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jul 2021 19:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 3909 X-GNU-PR-Package: emacs Original-Received: via spool by 3909-submit@debbugs.gnu.org id=B3909.16266361168560 (code B ref 3909); Sun, 18 Jul 2021 19:22:02 +0000 Original-Received: (at 3909) by debbugs.gnu.org; 18 Jul 2021 19:21:56 +0000 Original-Received: from localhost ([127.0.0.1]:57387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5CMN-0002Du-Kl for submit@debbugs.gnu.org; Sun, 18 Jul 2021 15:21:55 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:37192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5CML-0002Dd-Po; Sun, 18 Jul 2021 15:21:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ONMpFSDEeIeGFfZbqHbI26lr5Eq0hM/mXiH5bepmoe0=; b=VNqi5ORVrlUTp85WkEQqzHf1n6 YDt5qBGYFVF1enL542hjGHi3yRFUA7vln/qoo7eBxwtZhYALIOI49TxjMBtLWmtWZGtRyRG8ee/zZ ZPwhDtOK5YESm0tFPJNJldS3l0CxRmrzXhiuzc2ERuZ7cyttYZEgmf8YF4yShWenGlYc=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5CMC-0003Qp-FN; Sun, 18 Jul 2021 21:21:46 +0200 X-Now-Playing: David Bowie's _The Rise and Fall of Ziggy Stardust and the Spiders From Mars_: "Suffragette City" In-Reply-To: (Dani Moncayo's message of "Sat, 17 Nov 2012 22:37:36 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210213 Archived-At: Dani Moncayo writes: >>> Please, when a file is visited via drag-and-drop, add that file to the >>> history of visited files (so that I can revisit it with `C-x C-f M-p', >>> for example). I don't see the point of not doing that. >> >> On a related note, I've always found it irritating that the same is true >> of files specified on the command line: >> >> emacs -Q README & >> C-x C-k README RET >> C-x C-f M-p >> -> "Beginning of history; no preceding item" > > Indeed. The history of visited files should contain every visited > file, regardless of the way it was visited (command line argument, > drag-n-drop, menu item, C-x C-f...) The discussion here veered off into generalities, and nothing was done. The two practical suggestions were: 1) To add an optional parameter to `find-file' to make it push the filename onto `file-name-history'. Then we could adjust callers according to taste: I think drag and drop and command line arguments should land on the history. 2) To add a `display-buffer-hook' to do the same if the file actually ends up being displayed, so this pushing would happen deep in `find-file-noselect'. I think 1) is attractive in that it's very straightforward and simple to understand. 2) is attractive in that we don't put file names into the history unless we actually read the file, and we don't have to adjust function parameters for the other `find-file-*' commands, too. I think I prefer 1), because it's easier to reason about. Anybody got an opinion? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no