From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: master ab23fa4: Sort by recency in flex completion style when no flexy stuff happening Date: Thu, 19 Aug 2021 12:25:47 +0100 Message-ID: <87v941ptfo.fsf@gmail.com> References: <20210815123354.31232.42056@vcs0.savannah.gnu.org> <20210815123355.592B620B72@vcs0.savannah.gnu.org> <616ed0c3-525f-4975-d2dd-6818e4bcbe14@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37538"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 19 13:26:57 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mGgCH-0009VN-RW for ged-emacs-devel@m.gmane-mx.org; Thu, 19 Aug 2021 13:26:57 +0200 Original-Received: from localhost ([::1]:56484 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGgCG-0001Cr-Bc for ged-emacs-devel@m.gmane-mx.org; Thu, 19 Aug 2021 07:26:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGgBE-0000Vu-UE for emacs-devel@gnu.org; Thu, 19 Aug 2021 07:25:52 -0400 Original-Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:38897) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mGgBD-0008FK-Gk for emacs-devel@gnu.org; Thu, 19 Aug 2021 07:25:52 -0400 Original-Received: by mail-wm1-x336.google.com with SMTP id f13-20020a1c6a0d000000b002e6fd0b0b3fso4940582wmc.3 for ; Thu, 19 Aug 2021 04:25:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=DtwJ1sCM4Zd7nLf9vagUoOxizP9nywgJtHLikajEOuk=; b=H93FiPdMrP7GzqjU5OaFGaZlkwqZ49dgjiJ+4RJtowU6Cb9HZUjqMGoKHAg6p+yg8Z xnNuot4Zz+NX+82Nx7jByjpmiGCKFwNPz+cGTI95Q2Vj0ZB2hrbD1igJI6iQumdsNh63 2fpjZT4HqxRlXmv/KJsDQ9HbWvfVvBni7SiuKEaU5v5poxLm79Uq2e8Vh+D9ox4FnV51 E4D2qULUSAyv4nYKreNYacdyyGt1K+bDFImXf/e76r9N7FMR1iwJQsxH6bqZBj57+EFp oSbmfSJrM18JANCuPg4EwxKn7a/2af8z07FwPgTnyYYCS1AwcJ4lchhfmqd93E3gEcV3 qgLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=DtwJ1sCM4Zd7nLf9vagUoOxizP9nywgJtHLikajEOuk=; b=D5KuuRj8KwePGRVDc0j8F73GSPvrvLV+E8CfzksHD4612ORoPiA2bLuj+vpMP0Ec32 s9ZGwmX3Pk8WOhqnIYVUag3rXYuLaWmvq9TUuDZeCf/RcVxPffEjSQSzatTREYkyxYn+ vdmiU/GaBMCv//PebtTu5eLHnFC3YDhQ7Bw2mg0rPVn+NjEM27qDNenU7vvQWY64gDPQ ZgMr6mXYzAIYSa1tEcnjlDXoM2VRSsjeRyD5KrFZQj01ZJOYDc49rpb8UXHo5qQdNgOR J58EVoc5RK/zUXDBFwt7/lqBPdqqnrZY5lhzDtTrhT2V2KEeNDenlaOM680RPvScNCl8 mIoQ== X-Gm-Message-State: AOAM533unm8foIF3gZIF/uvzdYfKRT4A4j3P/2oR3i6wQ2hOuCxL75MM AKfavC2+A2Ji8Fw57lxbxcBkOC/A+1U= X-Google-Smtp-Source: ABdhPJzaSiIZpYmwmZe9OycBsQFjHv7r71fiGnSkNCsyjipBdh7tzSgIvAu2YrrmG2J7UN+JnWSy9Q== X-Received: by 2002:a1c:4d01:: with SMTP id o1mr13336491wmh.91.1629372349143; Thu, 19 Aug 2021 04:25:49 -0700 (PDT) Original-Received: from krug (a94-133-27-132.cpe.netcabo.pt. [94.133.27.132]) by smtp.gmail.com with ESMTPSA id y10sm8007187wmo.18.2021.08.19.04.25.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Aug 2021 04:25:48 -0700 (PDT) In-Reply-To: <616ed0c3-525f-4975-d2dd-6818e4bcbe14@yandex.ru> (Dmitry Gutov's message of "Tue, 17 Aug 2021 04:41:34 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=joaotavora@gmail.com; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272661 Archived-At: Dmitry Gutov writes: > On 15.08.2021 15:33, Jo=EF=BF=BDo T=EF=BF=BDvora wrote: >> Sort by recency in flex completion style when no flexy stuff happen= ing >> Fixes: bug#49888 >> * minibuffer.el (completion--flex-adjust-metadata): Fall >> back to usual >> alphanumeric, length, recency strategy if no minibuffer input. The= re >> is still a bug indicated by the nearby FIXMEs, though. > > On the balance, it's a good change, but I hope we can agree that it's > not really the proper place to choose the default sorting method. I've now pushed an adjusment for this fix that is functionally equivalent but duplicates no code of completion-all-sorted-completions at all. Thus, the "default" sorting method can be chosen there to be whatever. The flex style won't specify any display-sort-function/cycle sort function unless there is "flexy stuff happening". Jo=C3=A3o