From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#50195: [PATCH] Adding diary-offset, a diary-sexp offsetting another diary-sexp. Date: Wed, 25 Aug 2021 18:22:46 +0200 Message-ID: <87v93t3355.fsf@web.de> References: <87fsuychjr.fsf@ypei.me> <83mtp5vizs.fsf@gnu.org> <875yvtk9ud.fsf@gnus.org> <83fsuxvhih.fsf@gnu.org> <878s0p4kir.fsf@web.de> <835yvtv778.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30655"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: larsi@gnus.org, hi@ypei.me, 50195@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 25 18:24:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mIvhB-0007fN-Sy for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Aug 2021 18:24:09 +0200 Original-Received: from localhost ([::1]:39812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIvhA-00034r-Pb for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Aug 2021 12:24:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39200) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIvh4-00034h-GH for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 12:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35918) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mIvh4-0001wx-8U for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 12:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mIvh4-0006V1-56 for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 12:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Aug 2021 16:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50195 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50195-submit@debbugs.gnu.org id=B50195.162990858724911 (code B ref 50195); Wed, 25 Aug 2021 16:24:02 +0000 Original-Received: (at 50195) by debbugs.gnu.org; 25 Aug 2021 16:23:07 +0000 Original-Received: from localhost ([127.0.0.1]:47464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIvg8-0006Tg-17 for submit@debbugs.gnu.org; Wed, 25 Aug 2021 12:23:07 -0400 Original-Received: from mout.web.de ([212.227.15.4]:33929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIvg2-0006Sc-KC for 50195@debbugs.gnu.org; Wed, 25 Aug 2021 12:23:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1629908568; bh=9A1U2GGqCCkFgjuUpK93aSiuS7OZpgarMpychjhnrW8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=e6TfEBqCla9HnGNjA1oZfeFrzcgusv17OoWxGbuAM1qeDqintKsBxoOKOX3U9hFVb OYsAnKZGJ10hKRhwg3XdZD1SIyfCc0QRlgzcC9tykBXeeAgWV020zwiPxMudgJdvwX ygaQIgXZ83TzO2JGUYzy65bvzX7bzYTAoeWWA7Kk= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([88.66.201.45]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MA5tp-1mCYxV0DSj-00BLaK; Wed, 25 Aug 2021 18:22:48 +0200 In-Reply-To: <835yvtv778.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 25 Aug 2021 19:07:39 +0300") X-Provags-ID: V03:K1:2zvFub4XOBoZNXPng3gaGae2VV+DHH6M2Xa7TZESVmvy7BS+1sm GsccERWD1a3hironHgD8ln792/7Bay49t9BMljBQdxSdJ7T44bcfIv2jX7Is7433OpaPApB BNrnwyI5NTh/D0dh0hsvl0kCIkUubbQca4sn5JPgE8SgO7mTprwMjhu4SgEbIeEIEk2v6DI zBhH/hFXKA95L4okcX8yQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:sCW0t5uIwwk=:HEDWv8L2q/MNBJS4ncZ0mv lA9zug3O8vEPSLlr1C3o+3QvFKgkCGaX5ryiH2PjRXatOhjxqG1ygBMFCu02bAryFdKYqVkmP DZhQI/UTz+n0+O3zp0hpilvoSvafY+B0vwUw7tfcmk0q0mqccJhpMfaGOnDuLOt5J+4C7bFK+ xloTY15Dngk+PpF/HnfrjXPAV3IuktiaGnZCXAnpsxSKGy+IzmjYOWrNXstFGIgh+r3m+q2by LeiirAtBcPaqDv+9JwxTk1ySl1tmXiT6lcE2X43d1tL22LmLaJ5hKCDCZqJ8o4sLK1XYlZtEE WgVAfRHo19NaM/Gf16CYoJVQxKtPdbYks3K3OOoYXTYG5REYWk3+OUVN7E+pQfnKWEx18MUKV 9m06M/LUprzhGULCfWyEbHel0skHZrlmVMVbBqX8gMzkg2hUArQrOqfmeR7C/cBvkzAM/CnCh 7Mv1xmfo9rd/FOQ+1piPaqn2mmTpZWy22Hi6pTM41miENiNb0CS5s1ikBYQctA5PQMcjRHSfN vf6zfCPW60/jtqCY7NhnvU8ZEXhJmeNb6bdUs8/B/WyrTKJ5dYetpGKQTBsO9RPCnbo53eRJn MFt+HaIl2GMQ9t7pjIt1Qjk0FUGQpFvJ5JaJ2T43JxrSuU3m54vrd0Z/C7v7IdtEbQ6w1tOaS AtTovT1NQSQIBOAOeHca8d704CmZECG4LBlaLfHcqmnP2fBrYwEmKNvi5TqRoGFPe9bn4b0r0 g+sGp+JOmdSudQkXlBL80giwYTzhN4LkYOrmZwB//0MIYvKt+gXQYY4yah0Mn8z4wu1eXWLf X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212656 Archived-At: Eli Zaretskii writes: > > That would not work, you would still get warnings about free variables. > > I don't understand. This code did compile under dynamic-binding, so > what warnings did you have in mind? You can just try, they look like | In diary-list-entries-1: | diary-lib.el:731:17: Warning: reference to free variable =E2=80=98number= =E2=80=99 | diary-lib.el:734:48: Warning: reference to free variable =E2=80=98list-on= ly=E2=80=99 I just removed lexical-binding from the header and commented the `with-no-warnings' call in `diary-list-entries-1'. > > This case is a bit special and not directly related to lexical-binding > > because these variables are just not declared with `defvar' (and I think > > we don't want to introduce global variables like `date'). > > You are saying this always emitted warnings? AFAIR there have been problems with these variables and warnings about them for a long time, and different measures to handle them. I think (I'm not sure) we had (defvar date) in the file in the past. If you want to have any useful information you must ask Stefan, he was the one that worked on that. Michael.