From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50345: 28.0.50; [PATCH] Filling holes in css-mode.el Date: Fri, 03 Sep 2021 08:15:46 +0200 Message-ID: <87v93i4225.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7714"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50345@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 03 08:16:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mM2Uk-0001lr-OO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Sep 2021 08:16:11 +0200 Original-Received: from localhost ([::1]:46186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mM2Uj-00027P-J7 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Sep 2021 02:16:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mM2Uc-00026i-Bn for bug-gnu-emacs@gnu.org; Fri, 03 Sep 2021 02:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59283) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mM2Uc-0004cn-3w for bug-gnu-emacs@gnu.org; Fri, 03 Sep 2021 02:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mM2Ub-0006TE-RT for bug-gnu-emacs@gnu.org; Fri, 03 Sep 2021 02:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Sep 2021 06:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50345-submit@debbugs.gnu.org id=B50345.163064976024863 (code B ref 50345); Fri, 03 Sep 2021 06:16:01 +0000 Original-Received: (at 50345) by debbugs.gnu.org; 3 Sep 2021 06:16:00 +0000 Original-Received: from localhost ([127.0.0.1]:42596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM2Ua-0006Sx-2W for submit@debbugs.gnu.org; Fri, 03 Sep 2021 02:16:00 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:53440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM2UW-0006Si-3F for 50345@debbugs.gnu.org; Fri, 03 Sep 2021 02:15:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QJUJSbvAapdjhp3Ba02ViUUlVxqifywZxsdSbtkw+CU=; b=B/+f4VEABtwsG3LjTQN2FlWkEA 3GTgpUfVD9xQixpmPuWhFVcunBWYjU7NoSuCEJyCZ9HifY8rESjbfbGUWT6/Am9hsVsbqnLyemrf1 PErWxf/OsINQO1elORLw55FtR0BxN3HOCJZEsgQ3XjXbpmqvaTVGbyIGu2VT1InGRYG4=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mM2UM-0003Ay-J8; Fri, 03 Sep 2021 08:15:49 +0200 In-Reply-To: (Theodor Thornhill's message of "Thu, 02 Sep 2021 20:46:12 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213314 Archived-At: Theodor Thornhill writes: > Should I add several, smaller patches, or one big correction of most of > the things I see at the moment? Smaller patches are best, I think. Theodor Thornhill writes: > I moved the justify and align parts out from the flex block and into its > own block. I also took the liberty to add the `place' variants as well. > These are used a lot when using grid to set up your web page. I hope > this is usable. I see that some properties are extracted out into > variables, but not sure what is standard practice here. Both patches look good to me; pushed to Emacs 28 now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no