all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: miha--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Jim Porter <jporterbugs@gmail.com>, 50806@debbugs.gnu.org
Subject: bug#50806: 27.2; [PATCH] Optimize ansi-color.el
Date: Mon, 04 Oct 2021 12:07:09 +0200	[thread overview]
Message-ID: <87v92df6ia.fsf@miha-pc> (raw)
In-Reply-To: <87czolp2bd.fsf@gnus.org>

[-- Attachment #1: Type: text/plain, Size: 1801 bytes --]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> <miha@kamnitnik.top> writes:
>
>> Ok, thanks. I have actually already prepared patches for all these
>> features: full-color in ansi-color.el and term.el and also "basic" ANSI
>> escapes 1-8 for term.el that you mentioned.
>>
>> I guess there's no harm in sending them right now.
>
> We could apply both the patch to optimize ansi-color.el and add this new
> stuff now (to the Emacs trunk, i.e., Emacs 29), but there was some
> discussion about merging...  er...  something?  That I didn't quite
> understand?  :-)

Yeah sorry for the confusion. We were talking about "merging" two vector
variables of length 8 into one vector variable of length 16,
specifically, replacing the two
'ansi-color-*-colors-vector' variables with one
'ansi-color-colors-vector'.

These two variables are public and introduced in Emacs 28. If we wanted
to merge them, we'd have to do it on the Emacs-28 branch. However, the
performance gain from having them merged is negligible, so I think there
will be less complications if we just leave them as they are. This means
that patching Emacs-28 isn't required and all my patches from my second
mail onward are meant for Emacs 29.

>
> So just to clarify -- 
>
> Subject: [PATCH] Optimize ansi-color.el
>
> and
>
> Subject: [PATCH 2/4] Add support for 256-color and 24bit ANSI colors in ansi-color
>
> are independent patches, and they should both be applied to Emacs 29?

Yes, [PATCH] Optimize ansi-color.el (from my second e-mail)
and [PATCH 2/4] Add support for 256-color and 24bit ANSI colors in ansi-color

are meant to be applied to Emacs 29 on top of each-other.

>
> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  reply	other threads:[~2021-10-04 10:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-25 22:32 bug#50806: 27.2; [PATCH] Optimize ansi-color.el miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-03 16:31 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-03 17:53 ` Jim Porter
2021-10-03 19:54   ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-03 20:16     ` Jim Porter
2021-10-04 10:17       ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-03 19:59   ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-04  9:27     ` Lars Ingebrigtsen
2021-10-04 10:07       ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-10-05  6:56         ` Lars Ingebrigtsen
2021-10-05 11:18           ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-06  8:51             ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v92df6ia.fsf@miha-pc \
    --to=bug-gnu-emacs@gnu.org \
    --cc=50806@debbugs.gnu.org \
    --cc=jporterbugs@gmail.com \
    --cc=larsi@gnus.org \
    --cc=miha@kamnitnik.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.