From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51298: 29.0.50; Tab bar buttons won't highlight after the mouse is released outside the tab bar Date: Wed, 20 Oct 2021 15:40:05 +0800 Message-ID: <87v91sb0ve.fsf@yahoo.com> References: <87h7dcecex.fsf.ref@yahoo.com> <87h7dcecex.fsf@yahoo.com> <87lf2o41y1.fsf@mail.linkov.net> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2783"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 51298@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 20 09:42:51 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1md6FN-0000TQ-DO for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Oct 2021 09:42:49 +0200 Original-Received: from localhost ([::1]:42452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1md6FM-0001NT-5z for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Oct 2021 03:42:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1md6De-0007to-US for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 03:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41006) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1md6De-0007BK-LO for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 03:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1md6De-00043h-BN for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 03:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Oct 2021 07:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51298 X-GNU-PR-Package: emacs Original-Received: via spool by 51298-submit@debbugs.gnu.org id=B51298.163471562515546 (code B ref 51298); Wed, 20 Oct 2021 07:41:02 +0000 Original-Received: (at 51298) by debbugs.gnu.org; 20 Oct 2021 07:40:25 +0000 Original-Received: from localhost ([127.0.0.1]:52552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1md6D3-00042g-3w for submit@debbugs.gnu.org; Wed, 20 Oct 2021 03:40:25 -0400 Original-Received: from sonic305-20.consmr.mail.ne1.yahoo.com ([66.163.185.146]:34382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1md6D0-00042S-Mz for 51298@debbugs.gnu.org; Wed, 20 Oct 2021 03:40:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1634715616; bh=1DF1gP/DJEGlz7TbWDrZAA2qgFYJrRQgO4i2xX+eMIk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=juXYJ3Nt9y3n02K81K6fwt7NvZyH9YDiXPxsytedzuICosjPgVpXoxA/Mb9T6WqH4h2pogVP1MrPrAG8U+LCZKWpHHVq4f1UC14KheQM4ND4xouwmjPonzi4MVrZEWN+QkCO0i+nffkB/uCjtDpguL7JqwNNBFeUztuCiJQ/1usGrisGdfmKSWAsI+9QeLvCBOR7Jm3ZUsuoKnPMpy0b0RqibnHrHwIlqCnA/n3T/7i6Zi2Fo8Trvw1WwNktI8KJK9DNN1VUHLt1uUsVbVZwlojZPCT5lgLk3nJReRtF/hyftSbdzQDur5KU4MHqHNucguuIuO/lWX/Hze93aPHv0Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1634715616; bh=u5vC2mFS7jbnqqQPtH0LKVVxyeF7OCR87zimfSF6KcZ=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=oyEEhLvBmyuvo+fbpCxqOWLMKEZ+n2UoUwTi1e3FIVlnv+dY7L/ShaPF3GJrGWhpIGhv84p1gOnarZFzbEWSzDqndiEwtI6B5MK1goq0CxDAfXEE8MQpqV7kmLAfytn4yzpuOemLMjUh5rBsvEn5vz/DquOZKYNaCpseplSOGODY5LTT/HT8IInrYm92VzH7ZBJ5liCqYmX2wr43eHvkp9U5l99iPqjl4Jm/sypdCRirEWu5mUpfkUZVvYtSHGVICE3PyoKIpsUkAIQwf7xTZCANnGVNyMFcLQDWgo99LxvmtoruBEnTCQsMVIkkyNvSnLqZcZ99L+IKmakawFpRGQ== X-YMail-OSG: lMJZ7VMVM1lvde9KX1htpJmRE.3NX2T2yZOR7Oa..K7nv4pLSrPTWAk2sHl11zm qhcnsPqiKjMRLJpAksCxggYhVXHmL._PBPMmMhwU9WQ81vmwDQlNeYeKcP101.eY7bO85.3GyG4l P4MHc9kxZevzoRMJjvCHMVrq2v934MeXe1zqBdP9DuZF5wuWdF85c6oaG_JxKbuDEoo5ejtR7zFu fbqBaA.O0IWYC.S6Z9.M9pUigMyHFX401KfmNDxSnhNuat6cMgGWJmLrAb8omo6xI3Ojq3zYq.wk SD.9u8usinlQwFRcE1zpcU2ep1no6Rf2EKlwQGwkiko_A83UyLG2omJ7F7yASAyshmqNOBeVceJI 1.DXse2XsplPRA3zMsya1mDheVYJdyL6Z67sTz0Nb5nv_DlrjLFBc0fx9MXPNOHg.KSxQlkEZFd7 isNIRnBXPndrkhEdqy24mZMsPW7DVwsqbBYXSzU1hQ_H6gGk2F4bpLj0EMh78a0Q7tQsGl.3Srp4 4gbqzDRDWr8BGbRVSMmRISTQEMZneLIL4edYALwcCkBdXyyrBBn9RN484.oeALwCkPRLf.EOvnQF UBHZ3MWfId8n3ysgygLhqyADHHRhjS9cK1Aj4nFKt21kAg5sAzIVF_wWVHv3nSjbOE0C6VXtH2qg SiqrL6.0D0d_qNw4A6B_WJuJXJDlu8SOzUiaFqnxCtbPBFKBLsrfpJNc04QLkDqZK.dekGP6BBfB Bpflc7_UaG7H7SJv_u2AkoiOSwJebe_Vl6U2eedsQsLtp74nvLOf2xoW1_F3D.q7mxxoZBGhJnRd dr0jvcegxpoT63ypWLS8WjgU0L3uWGyDDP8CXYEtKR X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ne1.yahoo.com with HTTP; Wed, 20 Oct 2021 07:40:16 +0000 Original-Received: by kubenode514.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 9fdcb09b2887c8d48ff96a277c3ff901; Wed, 20 Oct 2021 07:40:12 +0000 (UTC) In-Reply-To: <87lf2o41y1.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 20 Oct 2021 09:58:46 +0300") X-Mailer: WebService/1.1.19116 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217633 Archived-At: --=-=-= Content-Type: text/plain Juri Linkov writes: > Patches welcome. Thanks, please test. The issue was because f->last_tab_bar_item wouldn't be cleared when the mouse click was dropped outside the tab bar. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-tab-bar-item-highlight-when-a-mouse-click-is-dro.patch >From 0b56777754cc5112c35c04d1da2a1154eed6e0bd Mon Sep 17 00:00:00 2001 From: Po Lu Date: Wed, 20 Oct 2021 15:36:59 +0800 Subject: [PATCH] Fix tab bar item highlight when a mouse click is dropped * src/xdisp.c (note_mouse_highlight): Clear last_tab_bar_item if the movement wasn't made on top of the tab bar. --- src/xdisp.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/xdisp.c b/src/xdisp.c index 1a65066ef9..888bf2d88d 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -33786,6 +33786,14 @@ note_mouse_highlight (struct frame *f, int x, int y) else return; } + else + { + /* The mouse might have pressed into the tab bar, but might + also have been released outside the tab bar, so + f->last_tab_bar_item must be reset, in order to make sure the + item can be still highlighted again in the future. */ + f->last_tab_bar_item = -1; + } #endif #if defined (HAVE_WINDOW_SYSTEM) && ! defined (HAVE_EXT_TOOL_BAR) -- 2.31.1 --=-=-=--