From: Lars Ingebrigtsen <larsi@gnus.org>
To: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Indentation of def*
Date: Wed, 20 Oct 2021 09:52:10 +0200 [thread overview]
Message-ID: <87v91s876d.fsf@gnus.org> (raw)
In-Reply-To: <E1md5NN-0003Cs-8i@fencepost.gnu.org> (Richard Stallman's message of "Wed, 20 Oct 2021 02:47:01 -0400")
Richard Stallman <rms@gnu.org> writes:
> Please keep the heuristic. It is still useful.
>
> If file A uses a deffoober construct defined in file B, and you visit
> file A with file B not loaded, the heuristic will make the uses of
> deffoober indent properly.
Or wrongly -- functions like `default-boundp' are indented wrongly using
that heuristic.
> The idea of this was that if you define something whose name starts
> with `def', it should be a defining construct. If people don't follow
> that convention, that's a mistake.
They don't follow that convention.
> Giving those macros explicit indentation properties is ok. With that
> done, the heuristic is no longer needed when their definitions are loaded.
>
> But I think we should still use the heuristic for any def... construct
> whose definition is not currenly loaded.
I don't see what makes these macros special. You have the same problem
with macros like `with-*' and `when-let' -- these also indent wrongly if
you haven't loaded their definitions.
The moral is: If you edit Emacs Lisp, you should load the file you're
editing first, otherwise it'll indent badly. We've plastered over this
"problem" for the def* macros only, but there's so many other macros
that also need special indentation that handling def* macros specially
is a disservice to everybody.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-10-20 7:52 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 23:13 Indentation of def* Lars Ingebrigtsen
2021-10-14 4:22 ` Stefan Monnier
2021-10-14 11:07 ` Po Lu
2021-10-14 11:14 ` Lars Ingebrigtsen
2021-10-14 11:23 ` Lars Ingebrigtsen
2021-10-14 12:05 ` Po Lu
2021-10-14 12:09 ` Lars Ingebrigtsen
2021-10-14 12:22 ` Po Lu
2021-10-14 12:49 ` João Távora
2021-10-14 13:40 ` Lars Ingebrigtsen
2021-10-14 21:41 ` João Távora
2021-10-15 9:57 ` Lars Ingebrigtsen
2021-10-15 10:14 ` João Távora
2021-10-14 13:25 ` Stefan Kangas
2021-10-14 13:30 ` Po Lu
2021-10-14 19:06 ` Stefan Kangas
2021-10-14 23:42 ` Po Lu
2021-10-15 0:50 ` Stefan Kangas
2021-10-15 5:21 ` Po Lu
2021-10-15 6:50 ` Eli Zaretskii
2021-10-15 8:35 ` Stefan Kangas
2021-10-15 10:42 ` Eli Zaretskii
2021-10-15 13:07 ` Stefan Kangas
2021-10-15 13:30 ` Eli Zaretskii
2021-10-15 13:48 ` Stefan Kangas
2021-10-15 13:17 ` Stefan Monnier
2021-10-15 12:42 ` Lars Ingebrigtsen
2021-10-15 12:43 ` Lars Ingebrigtsen
2021-10-14 18:35 ` Stefan Monnier
2021-10-18 8:02 ` Lars Ingebrigtsen
2021-10-20 6:47 ` Richard Stallman
2021-10-20 7:52 ` Lars Ingebrigtsen [this message]
2021-10-20 8:19 ` João Távora
2021-10-20 8:38 ` Lars Ingebrigtsen
2021-10-20 9:32 ` João Távora
2021-10-20 9:36 ` Lars Ingebrigtsen
2021-10-20 16:10 ` João Távora
2021-10-23 23:26 ` Richard Stallman
2021-10-24 13:22 ` Lars Ingebrigtsen
2021-10-24 14:27 ` Stefan Kangas
2021-10-24 15:19 ` João Távora
2021-10-24 16:23 ` Stefan Monnier
2021-10-24 16:55 ` Lars Ingebrigtsen
2021-10-24 18:36 ` João Távora
2021-10-27 14:37 ` Richard Stallman
2021-10-27 14:36 ` Richard Stallman
2021-10-27 14:40 ` Lars Ingebrigtsen
2021-10-30 6:49 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v91s876d.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.