From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 1914d94 2/2: Change how Dired displays available space Date: Thu, 02 Dec 2021 16:41:08 +0100 Message-ID: <87v90710bv.fsf@gnus.org> References: <20211201222724.19544.19533@vcs0.savannah.gnu.org> <20211201222726.7AFF521362@vcs0.savannah.gnu.org> <87wnknm4zb.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25677"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 02 16:44:14 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msoFp-0006Tb-7x for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Dec 2021 16:44:13 +0100 Original-Received: from localhost ([::1]:47180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msoFn-0005B6-9R for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Dec 2021 10:44:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msoD2-00076x-Si for emacs-devel@gnu.org; Thu, 02 Dec 2021 10:41:20 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=58628 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msoD1-0003lF-AV for emacs-devel@gnu.org; Thu, 02 Dec 2021 10:41:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=94/0vEPH2yO+VliQ1eIqW6UMs1HzXBnTqjbETMn4BbI=; b=ZpElL6C9DVNHzxyGefUPDL1yYG djPqYOLyHFd2HZxCk7Gvb/M5m/gxclQn+FHPubELBUvBZEy5+AwgImvfqw8YvrAHyq+HOoStfQyFn WewgqAencmf/CJ5m8FZjoxFWPjAYfTXQs2KcmyJhvi+y143glGsjLzLVMlmyK6CDm7XA=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msoCt-0002Ht-SI; Thu, 02 Dec 2021 16:41:15 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEXQ8Pykzr/7/PPt 8s/f5a59k3P////3cTrHAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+UMAg8QGy5fmZsAAAGZSURBVDjL nZPBboMwDIbbSrvjEe6t091LnN0b2b0vGn7/V5mTEqBbpUm1EEL5+H87drLb/RP7breDDvb7vwQa /z+wvGATTYWIBI/RNeDjL7IoJD1VeCmxAZc78LGC5EzmwNnnDEhkyCzwTcmZzsC1AjOqv8L34QxV O4MonDyoug4x1XU+NnDLo/byXgATUWhABgWFaIpiZeS45FCdPvovxJElGrg0IKrgJ7MaqVg1ULxy 4lCAZwp+Bni2jkzi+qooKYTvIHphjc4ZiJ5WKzwByQCu7IPsCeRngDRacqD3A45jb6ApED+tXFc2 GG8Tepw3aCDlIfXcH/CkqkJ6bWDIWTkA4t6ADrqM9pTdFMgZKNMYZFGgkAS0HJ/WrOg4LYeBooGA +JbBEaVVURoZerOyAUdxS7lWp7WbEc/3CT4C5lJFORXTxsoax1cDanPWKa8Kiny30ly2sgIfE0l1 lFvSjcKWyIVag1gXNla20nlvp8Sn2yZ5TcIB65yELw9AYsA5jpvk9qPDJyAgUf8MPMar4OWwO7ze /VfiB8wrhoIKJgx3AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTEyLTAyVDE1OjE2OjI3KzAwOjAw RvXe9wAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0xMi0wMlQxNToxNjoyNyswMDowMDeoZksAAAAA SUVORK5CYII= X-Now-Playing: Steve Hackett's _Voyage of the Acolyte_: "Star of Sirius" In-Reply-To: <87wnknm4zb.fsf@gmx.de> (Michael Albinus's message of "Thu, 02 Dec 2021 15:55:04 +0100") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280758 Archived-At: Michael Albinus writes: > Hmm. insert-directory can be used w/o being called from dired. And there > are further implementations of insert-directory, because it uses file > name handlers. So these functions must be adapted as well. My assumption was that (as for the first bit) that not translating the "total x" thing wouldn't be catastrophic, so that could be adjusted afterwards. As for the other implementations, I assumed that they would just continue to work as is, and if they do that "total" transformation, it would be trivial to just remove that bit. If this causes major problems, I'm sorry. > Granted, most of them are from Tramp, but there could be also other > implementations in the wild. > > Is there a shiny reason to move this functionality from insert-directory > to dired-insert-directory? A discussion about, or at least a trigger for > this change (aka announcement in etc/NEWS), would have been appreciated. I implemented this first as a part of insert-directory. But the problem is that it's dired itself that prepends the /current/path/name at the top, so the thing had to go to dired. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no