From: <jakanakaevangeli@chiru.no>
To: sds@gnu.org, 52467@debbugs.gnu.org
Cc: Theodor Thornhill <theo@thornhill.no>
Subject: bug#52467: 29.0.50; Use pop-to-buffer for shell
Date: Tue, 14 Dec 2021 16:59:09 +0100 [thread overview]
Message-ID: <87v8zrch4i.fsf@miha-pc> (raw)
In-Reply-To: <lzpmq05vka.fsf@3c22fb11fdab.ant.amazon.com>
Steingold <sds@gnu.org> writes:
> Hi
> I would like to request reverting of the patch
>
> 70b64e0d040e9c57f1a489c9ebee553264033119 "Use pop-to-buffer-same-window for shell"
>
> When I already have a window with shell, this patch creates a second
> such window.
Maybe you could try customizing display-buffer-alist. To prevent
creation of duplicate windows showing the same shell buffer, do
(add-to-list 'display-buffer-alist
'("\\`\\*shell\\*\\'" display-buffer-reuse-window))
> It seems much more reasonable to use pop-to-buffer in eshell rather than
> break shell's behavior.
For old behaviour of popping up a new shell window, do
(add-to-list 'display-buffer-alist
'("\\`\\*shell\\*\\'"
(display-buffer-reuse-window display-buffer-pop-up-window)))
> If you insist on your desired behavior, please add a user variable
> `shell-pop-to-buffer-action` that you would set to
> `display-buffer--same-window-action`.
display-buffer-alist is flexible enough to customize this behaviour, no
need for a new user option in my opinion.
Best regards.
prev parent reply other threads:[~2021-12-14 15:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 16:16 bug#52467: 29.0.50; Use pop-to-buffer for shell Steingold
2021-12-13 21:14 ` Dmitry Gutov
2021-12-14 8:19 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-19 13:14 ` Lars Ingebrigtsen
2021-12-19 23:34 ` Dmitry Gutov
[not found] ` <CADwFkm=60K=ttDtK+z5v1Ch=qDUbng42jkyzV-7vLeC8zKLq6A@mail.gmail.com>
2021-12-20 10:17 ` Lars Ingebrigtsen
2021-12-24 0:38 ` Sam Steingold
2021-12-24 0:51 ` Dmitry Gutov
2021-12-24 9:07 ` Lars Ingebrigtsen
2021-12-26 0:47 ` Dmitry Gutov
2021-12-26 11:35 ` Lars Ingebrigtsen
2021-12-26 15:37 ` Dmitry Gutov
2021-12-26 17:00 ` Sam Steingold
2021-12-27 9:32 ` jakanakaevangeli
2021-12-27 12:01 ` Lars Ingebrigtsen
2021-12-14 15:59 ` jakanakaevangeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8zrch4i.fsf@miha-pc \
--to=jakanakaevangeli@chiru.no \
--cc=52467@debbugs.gnu.org \
--cc=sds@gnu.org \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.