Re: [elpa] externals/transient 459e28e28a 03/11: Add lisp-imenu-generic-expression entry

Re: [elpa] externals/transient 459e28e28a 03/11: Add lisp-imenu-generic-expression entry

[Stefan Monnier]

> --- a/lisp/transient.el
> +++ b/lisp/transient.el
> @@ -3638,6 +3638,19 @@ search instead."
>  
>  ;;;; Miscellaneous
>  
> +(with-eval-after-load 'lisp-mode
> +  (cl-pushnew (list nil (concat "^\\s-*("
> +                                (eval-when-compile
> +			          (regexp-opt
> +			           '("transient-define-prefix"
> +                                     "transient-define-suffix"
> +                                     "transient-define-infix"
> +                                     "transient-define-argument")
> +                                   t))
> +		                "\\s-+\\(" lisp-mode-symbol-regexp "\\)")
> +	            2)
> +              lisp-imenu-generic-expression :test #'equal))

Hmm... `lisp-mode` doesn't seem right since that's the mode used for
Common-Lisp (yes, I know, here you're referring to the file, which
confusingly defines a lot more than just the `lisp-mode`).
I think `elisp-mode` would be closer to the truth.

Then again, they're both preloaded, so the `with-eval-after-load` can be
completely skipped.

BTW, I wish we had some kind of `register-defining-form` function which
would take care of tweaking the `imenu-generic-expression` as well as
the `font-lock-keywords` of elisp-mode.


        Stefan

Re: [elpa] externals/transient 459e28e28a 03/11: Add lisp-imenu-generic-expression entry

[Jonas Bernoulli]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> +(with-eval-after-load 'lisp-mode

> Then again, they're both preloaded, so the `with-eval-after-load` can be
> completely skipped.

Done.  I won't push that until in a few days to avoid some rebasing.

> BTW, I wish we had some kind of `register-defining-form` function which
> would take care of tweaking the `imenu-generic-expression` as well as
> the `font-lock-keywords` of elisp-mode.

Sure, that would be nice.  ;)

Or (declare something).

     Jonas