From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew Cohen Newsgroups: gmane.emacs.devel Subject: Re: Emacs pretest 28.0.92 is out Date: Sun, 20 Mar 2022 14:04:23 +0800 Message-ID: <87v8w9tb14.fsf@ust.hk> References: <83ilshlokm.fsf@gnu.org> <87v8wb2x54.fsf@gnu.org> <83wngrfj02.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10305"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: emacs-devel@gnu.org Cancel-Lock: sha1:Q2Yjbm/wEGj1hSu/ydg6yqOczJg= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 20 07:10:18 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVole-0002au-3L for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Mar 2022 07:10:18 +0100 Original-Received: from localhost ([::1]:51014 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVolc-0002Kv-AZ for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Mar 2022 02:10:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVog6-0008GV-CH for emacs-devel@gnu.org; Sun, 20 Mar 2022 02:04:35 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:49278) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVog4-0000O3-Pd for emacs-devel@gnu.org; Sun, 20 Mar 2022 02:04:34 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nVog1-0005tq-1i for emacs-devel@gnu.org; Sun, 20 Mar 2022 07:04:29 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287312 Archived-At: >>>>> "EZ" == Eli Zaretskii writes: [...] >> I do not know as how mature the third pretest is ranked. >> Personally, I find bug 54158 very annoying; it is a regression >> compared with Emacs 27. Please, let me know if there is anything >> I can help debugging it. Unfortunately, it goes beyond my >> expertise. EZ> Eric, Lars, can we solve that bug soon, please? Below is a patch that fixes this bug. Note that I don't believe it is a regression but seems to have been around for quite some time. Subject: [PATCH] Fix imap fetching multiple mailboxes (bug#54158) * lisp/gnus/mail-source.el (mail-source-fetch-imap): Variables mailbox-source-string and remove should be reset for each mailbox. --- lisp/gnus/mail-source.el | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lisp/gnus/mail-source.el b/lisp/gnus/mail-source.el index 04de70bf0f..320bc9c3b0 100644 --- a/lisp/gnus/mail-source.el +++ b/lisp/gnus/mail-source.el @@ -1065,9 +1065,7 @@ mail-source-fetch-imap (let ((from (format "%s:%s:%s" server user port)) (found 0) (buf (generate-new-buffer " *imap source*")) - (mail-source-string (format "imap:%s:%s" server mailbox)) - (imap-shell-program (or (list program) imap-shell-program)) - remove) + (imap-shell-program (or (list program) imap-shell-program))) (if (and (imap-open server port stream authentication buf) (imap-authenticate user (or (cdr (assoc from mail-source-password-cache)) @@ -1076,8 +1074,10 @@ mail-source-fetch-imap (let ((mailbox-list (if (listp mailbox) mailbox (list mailbox)))) (dolist (mailbox mailbox-list) (when (imap-mailbox-select mailbox nil buf) - (let ((coding-system-for-write mail-source-imap-file-coding-system) - str) + (let ((coding-system-for-write + mail-source-imap-file-coding-system) + (mail-source-string (format "imap:%s:%s" server mailbox)) + str remove) (message "Fetching from %s..." mailbox) (with-temp-file mail-source-crash-box ;; Avoid converting 8-bit chars from inserted strings to -- 2.34.1.575.g55b058a8bb -- Andrew Cohen