Re: Problem with native-compilation

[Felix Dietrich <felix.dietrich@sperrhaken.name>]

[-- Attachment #1: Type: text/plain, Size: 2592 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> What is org-contacts.el?  I don't see it in Emacs.

Itʼs part of org-contrib whose package currently resides here
<https://elpa.nongnu.org/nongnu/org-contrib.html>.  Org-contrib used to
be part of the org-mode repository but was removed with version 9.5.  I
do not know whether it was, together with org-mode, imported into the
Emacs tree.

>> From: Jonas Damm <emails@jonas-damm.de>
>> Date: Thu, 24 Mar 2022 23:17:38 +0100
>
>> After installing
>> the org-contacts package from nongnu org-contrib, at first everything
>> works as expected.
>> 
>> However, after the compiling in the background is done, some functions
>> are broken:
>> 
>> 
>> Warning (comp): org-contacts.el:648:13: Warning: the function ‘start’ is not known to be defined. Disable showing Disable logging
>> Warning (comp): org-contacts.el:593:12: Warning: the function ‘lexical-let*’ is not known to be defined. Disable showing Disable logging
>> Warning (comp): org-contacts.el:505:4: Warning: the function ‘list*’ is not known to be defined. Disable showing Disable logging
>> Warning (comp): org-contacts.el:459:4: Warning: the function ‘lexical-let’ is not known to be defined. Disable showing Disable logging
>> Warning (comp): org-contacts.el:372:28: Warning: the function ‘values’ is not known to be defined. Disable showing Disable logging
>> Warning (comp): org-contacts.el:330:44: Warning: the function ‘first’ is not known to be defined. Disable showing Disable logging
>
> From the messages you show, it sounds like org-contacts.el has
> problems that are flagged by the native compilation, in particular it
> needs to (require 'cl) (for lexical-let*) and probably other packages
> to resolve the other "not known to be defined" problems.

Can or should (require 'cl) be wrapped in a ‘eval-when-compile’?  What
is the state of the cl library?  It is marked as obsolete.  Are there
plans on how long it will be supported?

Anyway, Jonas, attached is a patch that cleans up the compilation errors
and warnings (at least ‘batch-byte-compile’ is satisfied).  If you have
not yet gotten around to it yourself then this might be useful for you.
I did not dispense with ‘lexical-let’ by activating ‘lexical-binding’
because I did not want to read all of the code to see whether
org-contacts makes use of implicitly dynamically bound variables.  The
patch applies to the current master (8c138dc) of the git repository of
the org-contrib package <https://git.sr.ht/~bzg/org-contrib/tree>.


[-- Attachment #2: Patch to clean-up compilation errors in org-contacts.el --]
[-- Type: text/x-diff, Size: 2317 bytes --]

From b4444ae5f46b6edbb9064d2f2be5c4e2e1851948 Mon Sep 17 00:00:00 2001
From: Felix Dietrich <felix.dietrich@sperrhaken.name>
Date: Sat, 26 Mar 2022 13:58:03 +0100
Subject: [PATCH] org-contacts: Fix compilation warnings and erros

---
 lisp/org-contacts.el | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/lisp/org-contacts.el b/lisp/org-contacts.el
index 94be38a..2866fff 100644
--- a/lisp/org-contacts.el
+++ b/lisp/org-contacts.el
@@ -62,6 +62,7 @@
 ;;; Code:
 
 (require 'cl-lib)
+(eval-when-compile (require 'cl)) ; for ‘lexical-let’
 (require 'org)
 (require 'gnus-util)
 (require 'gnus-art)
@@ -749,8 +750,8 @@ This function should be called from `gnus-article-prepare-hook'."
       (with-current-buffer (marker-buffer marker)
         (save-excursion
           (goto-char marker)
-          (let* ((org-email-link-description-format (or org-contacts-email-link-description-format
-                                                        org-email-link-description-format))
+          (let* ((org-link-email-description-format (or org-contacts-email-link-description-format
+                                                        org-link-email-description-format))
                  (link (gnus-with-article-buffer (org-store-link nil))))
             (org-set-property org-contacts-last-read-mail-property link)))))))
 
@@ -1169,14 +1170,14 @@ are effectively trimmed).  If nil, all zero-length substrings are retained."
 	     (member (buffer-file-name) (mapcar 'expand-file-name org-contacts-files)))
     (if (bound-and-true-p org-id-link-to-org-use-id)
 	(org-id-store-link)
-      (let ((headline-str (substring-no-properties (org-get-heading t t t t))))
-	(org-store-link-props
+      (let* ((headline-str (substring-no-properties (org-get-heading t t t t)))
+	     (link (concat "org-contact:" headline-str)))
+	(org-link-store-props
 	 :type "org-contact"
 	 :link headline-str
 	 :description headline-str)
-        (setq desc headline-str)
-        (setq link (concat "org-contact:" headline-str))
-        (org-add-link-props :link link :description desc)
+        (org-link-add-props :link link
+			    :description headline-str)
         link))))
 
 (defun org-contacts--all-contacts ()
-- 
2.35.1


[-- Attachment #3: Type: text/plain, Size: 20 bytes --]


-- 
Felix Dietrich