From: Ihor Radchenko <yantar92@gmail.com>
To: Karl Fogel <kfogel@red-bean.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: Removing obsolete function `org-truely-invisible-p'.
Date: Mon, 04 Apr 2022 19:55:58 +0800 [thread overview]
Message-ID: <87v8vpf4fl.fsf@localhost> (raw)
In-Reply-To: <87fsmx8x62.fsf@red-bean.com>
Karl Fogel <kfogel@red-bean.com> writes:
>>Could you prepare a patch? Having a patch may encourage more
>>feedback.
>
> Sure; please see attached.
Thanks! Marking your message as a patch to be tracked at
updates.orgmode.org
> From bb229b4f8f78ae52962d7bc90c8b1d4993af8263 Mon Sep 17 00:00:00 2001
> From: Karl Fogel <kfogel@red-bean.com>
> Date: Thu, 31 Mar 2022 19:02:38 -0500
> Subject: [PATCH] Mark function obsolete & fix spelling of its name
This commit message is a bit confusing. I would mention the function
name: "Mark `org-truely-invisible-p' obsolete and fix spelling of its
name"
> * lisp/org-macs.el (org-truely-invisible-p): Move to...
> * lisp/org-compat.el (org-truly-invisible-p): ...here, and add...
> (org-truely-invisible-p): ...this compatibility alias.
It is too much.
We can either
1. Obsolete org-truely-invisible-p. Then, there is not much point
renaming it.
2. Rename it without obsoletion. Then, there is not much point moving
the function definition to org-compat.
> From: Ihor Radchenko
> Subject: Re: Removing obsolete function `org-truely-invisible-p'.
> To: Karl Fogel
> Cc: Org Mode
> Date: Sun, 19 Dec 2021 17:14:32 +0800
> Message-ID: <87h7b5rm6f.fsf@localhost>
I usually just leave an ML link in such cases:
https://orgmode.org/list/87h7b5rm6f.fsf@localhost
Best,
Ihor
next prev parent reply other threads:[~2022-04-04 11:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 20:53 Removing obsolete function `org-truely-invisible-p' Karl Fogel
2021-12-04 22:19 ` Samuel Wales
2021-12-19 9:14 ` Ihor Radchenko
2022-04-01 0:28 ` Karl Fogel
2022-04-04 11:55 ` Ihor Radchenko [this message]
2022-04-04 16:20 ` Karl Fogel
2022-04-05 6:14 ` Ihor Radchenko
2022-04-05 17:08 ` Linking by Message-ID Max Nikulin
2022-04-05 18:41 ` Removing obsolete function `org-truely-invisible-p' Karl Fogel
2022-04-07 4:59 ` Ihor Radchenko
2022-04-07 16:57 ` Karl Fogel
2022-04-15 9:33 ` [PATCH] CONTRIBUTE: Link WORG page when explaining commit message format Ihor Radchenko
2022-04-15 12:47 ` Robert Pluim
2022-04-15 21:13 ` Karl Fogel
2022-04-16 9:35 ` Ihor Radchenko
2022-04-23 8:06 ` Ihor Radchenko
2022-04-23 15:47 ` Karl Fogel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8vpf4fl.fsf@localhost \
--to=yantar92@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=kfogel@red-bean.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.