all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: emacs-devel@gnu.org
Cc: Pip Cet <pipcet@gmail.com>
Subject: Re: master fa52782f5c: Make timer_check even more resilient
Date: Fri, 29 Apr 2022 20:40:09 +0800	[thread overview]
Message-ID: <87v8usvz9y.fsf@yahoo.com> (raw)
In-Reply-To: <20220429121523.D82E8C06322@vcs2.savannah.gnu.org> (Lars Ingebrigtsen's message of "Fri, 29 Apr 2022 08:15:23 -0400 (EDT)")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> +  block_input ();
> +  turn_on_atimers (false);
>  
>    /* We use copies of the timers' lists to allow a timer to add itself
>       again, without locking up Emacs if the newly added timer is
> @@ -4646,6 +4648,8 @@ timer_check (void)
>    else
>      idle_timers = Qnil;
>  
> +  turn_on_atimers (true);
> +  unblock_input ();

Does input really have to be blocked around this?

The call to `unblock_input' will end up reading async input, which might
not be safe at that spot.  (The X11 drag and drop code used to suffer
from this problem, and debugging the resulting crashes was not easy.)



       reply	other threads:[~2022-04-29 12:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165123452355.15775.3995648788143039474@vcs2.savannah.gnu.org>
     [not found] ` <20220429121523.D82E8C06322@vcs2.savannah.gnu.org>
2022-04-29 12:40   ` Po Lu [this message]
2022-04-29 12:53     ` master fa52782f5c: Make timer_check even more resilient Po Lu
2022-04-29 13:19     ` Lars Ingebrigtsen
2022-04-29 13:24       ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8usvz9y.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=emacs-devel@gnu.org \
    --cc=pipcet@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.