From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master f8b2a01a9e: * lisp/shell.el (shell): Query shell file name from `interactive` Date: Sat, 28 May 2022 18:18:17 +0200 Message-ID: <87v8tpwrzq.fsf@gmx.de> References: <165365729037.13166.16983049289085077158@vcs2.savannah.gnu.org> <20220527131450.B347BC01683@vcs2.savannah.gnu.org> <87zgj2vwtz.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34031"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 28 18:19:58 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuzAS-0008aj-KB for ged-emacs-devel@m.gmane-mx.org; Sat, 28 May 2022 18:19:56 +0200 Original-Received: from localhost ([::1]:33666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuzAR-0007TC-6L for ged-emacs-devel@m.gmane-mx.org; Sat, 28 May 2022 12:19:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuz8z-0006kE-9Q for emacs-devel@gnu.org; Sat, 28 May 2022 12:18:25 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:40385) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuz8x-00025a-BM for emacs-devel@gnu.org; Sat, 28 May 2022 12:18:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1653754699; bh=OZjLBj4Tbtio8VORcUf3hnspZinu+U+g0OB5dt8qIks=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=ai+PdYqg9XovepZ3SvwPZThZHHebjzu0AvfdZe6rDDyHVh324aSui5u2YkfThmfKg Vg7/NjQUu39kWWQvqKK+8kDH423HlXnohWI9upnGX6YAzZyKFaCTilYFX8edNNv44A tlKNDdC8kYT5S/NL7onpc5j7HEdVGsUURpNnQVbo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([79.140.118.129]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MgvvT-1nL71q17V7-00hOPt; Sat, 28 May 2022 18:18:19 +0200 In-Reply-To: (Stefan Monnier's message of "Sat, 28 May 2022 11:31:04 -0400") X-Provags-ID: V03:K1:Di3ebCECIOeuc8G6UYlkX7Uvu5ij6CSEFpmM3+P0EEfSQc26SIi 3MT3OT/E5cLVeE0MsQja/O7DIdVV0EqjZy1Fougf/pqqWL4RAAdNUu7sPCQJj5/spyY3LDr ejSWeEayBaHvyAQDZ4Se2M0hH0zW3apdaZzfaVDJb0VU4IgLqYzhPIbJfwUB2KNPpdxEorv uaMfjCbU5slYMpVa8+4PA== X-UI-Out-Filterresults: notjunk:1;V03:K0:LBwcBoLJObk=:y5Ktnbke/WvELwqAp4VQ6I Oh8W0G/vs8YCK7gASya/nz6Pnf2pHtSPlLfZh0rz0n7eRwHOMeK8TfOQIwYI8uIszYmG4ugYL 8KShRXe9r5++zBHb7DWYbdWhCl2FTELMfxvf9hfN0IrQ+3QeBRZWGMk+QzmP2xvdDOdcfH4EI uFnW4yA9UZStbVoQ9xN5RRrhVjVzOieqCBouNzKPLZ+yEhywoea/iB5en0/rxK6MmrB8eWyjg GfzWrZWMXxvKSNooWiuVoUbrFCp+UywP1TaXcoQHnoxYWN9MFEqvuZt1eCXgvMye+hSR3a4ll iE0Hucoc9zI0SmIpydpnEDRxWiCCCuWvXxlwDhpeBpVSRVD86iQKN0GdifpB4tZAHkt77tZ43 0H4qGpRaRogbLqBcR9bv3wHjFurwODm2x/evr0gpOssoOeXD4XIoFGHHWcpPmirZEtmjbPXgR xG5M7WQ01M3/czL7T5XNScuTzbj7yHfz+CTr6P1x+LKX6wyxi+39A6JCCJGU05+h03WyBbU65 tOioAs//IwrMA5oZY5qT99Ckm6A0491QDW6oKcCEUjcjtPC162U0tAg5UcrFGeJTSMjoQO8s6 ZkXl/5ee6B6mVOPvt5+Oz/xWwotQo8MYXp0QYQkbgKgidCMR7wLLgeP7hI/RPQwCUkSF0wrMn Oi6oPwxClShguqSPgbLl5wwlpgWloiI8wStBlnFypzhfq8965gzye5shq0d10LHTtTLrVCZ6e vlYqA8rcvD7g/8bLBt/OiNNpclS96bQCMUVnwNfHc+VYU2mMrryUI5aOFBCCO3sPh6rrrOIK Received-SPF: pass client-ip=212.227.15.18; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290340 Archived-At: Stefan Monnier writes: Hi Stefan, > Does the patch below look correct to you? > It also tries to address the FIXME while we're at it. I'm not sure. You use `buffer', and not `buf' for the interactive spec. OTOH, you set `default-directory' in `buf', which might cure it. Anyway, it would be an incompatible (but appreciated) change. If you have an existing shell buffer, it would be reused as-it-is, and you cannot change its remoteness. Something, which has been plagued me since ever. Hmm, do we have test cases for this, for both the local and the remote case, for both an existing and a new shell buffer? (If not, I could volunteer to write them, but it might take some days then.) > Stefan Best regards, Michael.