From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id AMc/K9JF3WIyTQEAbAwnHQ (envelope-from ) for ; Sun, 24 Jul 2022 15:14:58 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mAFGKtJF3WJMEAEAG6o9tA (envelope-from ) for ; Sun, 24 Jul 2022 15:14:58 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 47AE220DD5 for ; Sun, 24 Jul 2022 15:14:58 +0200 (CEST) Received: from localhost ([::1]:42220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oFbRg-0004Uj-K7 for larch@yhetil.org; Sun, 24 Jul 2022 09:14:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFbRF-0004Ub-5B for emacs-orgmode@gnu.org; Sun, 24 Jul 2022 09:14:29 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:35659) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oFbRD-0007dh-MN for emacs-orgmode@gnu.org; Sun, 24 Jul 2022 09:14:28 -0400 Received: by mail-pf1-x42c.google.com with SMTP id c139so8203909pfc.2 for ; Sun, 24 Jul 2022 06:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=Nk0y5oQQsQ4d9ni8IQKtLOu1y8lAk6vMrY6j1Uzo4qE=; b=oRd+69bbFLHpMKyAztsxXFo7AcES/tNpGHlbq7CohNlbd99xsDNhVvnUK8O20ZjOPN GI0WvMmNuhuE7h8zL8VxaYaIkLTpmfcepxrD/BBrEtGJJaDCO9w5wnbOw32SRJ1EQmps wi+PztSTR2tBE+qsrnn+/ATvXldwM0NEiXD6Zu99XPOx0J4b3NLEPBkNMoK3h2UoZ2UW zG5Eie/xvSfTUFlAyemZyx7o/O1J/s2GRBQFp/EoOvOB1O1xsfn/9o/c8JTFWF127HTt u9ASNpQxwj7owA1qEpE46TPFsVtcEKFQR3BVtqTV0dTb3djpKn5V7025vv2x8474CfWD rF+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=Nk0y5oQQsQ4d9ni8IQKtLOu1y8lAk6vMrY6j1Uzo4qE=; b=jiPKWQVSA06z6NZGm3kCKNHIPvrwLUj2KJqqlwgES33bD1emg7A+0P5pnfSR8sOz/v 8QF1/ClY6WqRSaj0qpYBVnp9wAS9sGjxJO94rXyIJdZyWC55Mslrxx6/wDTJOWMn+fQm ISks2LjbnkheKmbW4OT791OP0c6rjPWIQpW/YrKWcUpqpBlafjVVgTh510mCU/V5pIXm EJ7JVusLLPtUaJ9r7Rznau3CPohUO36BzPsH1gxAmQ+hgkTvpVMWr/9+CIMcfOCWs9fa g0JXU+pk6e5XHih6JoZJXMpQy+1Z6LOyoVyrm1/A1yTMCdoiAffsQTO4xwAoeNHgNtJn m6yQ== X-Gm-Message-State: AJIora85LGu2PkQx+mFTVcqynNJJ/2h9szbVLWG8dWBO+PMjz6xrNLAo lwM8a1a47Z66d9PNbsFBXF8= X-Google-Smtp-Source: AGRyM1so1izz15v+M2gR1quDvb0FbpcNJ36XHpF7chd5CMqTeRufq+AoIy/8a66DLzu273QKe9z17w== X-Received: by 2002:a65:6bcc:0:b0:3f6:1815:f541 with SMTP id e12-20020a656bcc000000b003f61815f541mr7088549pgw.183.1658668466070; Sun, 24 Jul 2022 06:14:26 -0700 (PDT) Received: from localhost ([2409:8a70:217:4f80:8ec6:81ff:fe70:339d]) by smtp.gmail.com with ESMTPSA id g4-20020a170902868400b0016d22e6ed57sm7101491plo.293.2022.07.24.06.14.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Jul 2022 06:14:25 -0700 (PDT) From: Ihor Radchenko To: Max Nikulin Cc: Hugo Heagren , emacs-orgmode@gnu.org Subject: Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters In-Reply-To: References: <87zgl1npow.fsf@localhost> <20220405192931.6747-1-hugo@heagren.com> <87a6cx79xn.fsf@localhost> <87zgi6fckr.fsf@heagren.com> <871qvixhfw.fsf@gmail.com> <87v8s8n1bm.fsf@heagren.com> <87let39d3c.fsf@localhost> <877d4flu3x.fsf@heagren.com> <87cze5e84m.fsf@localhost> <87tu7gkb4l.fsf@heagren.com> <87y1ws6o0c.fsf@localhost> <87k08bjw0t.fsf@heagren.com> <47248a4f-10aa-0980-c054-563f30c05aaa@gmail.com> <87mtd0gthe.fsf@heagren.com> <78b97c9e-fced-0ee4-f3f2-3cbe81080ffa@gmail.com> <87sfms9dx7.fsf@localhost> Date: Sun, 24 Jul 2022 21:15:31 +0800 Message-ID: <87v8rmd53g.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=yantar92@gmail.com; helo=mail-pf1-x42c.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658668498; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Nk0y5oQQsQ4d9ni8IQKtLOu1y8lAk6vMrY6j1Uzo4qE=; b=oWakMEBdIeiAK4bQLKSpn9p5Fcjtko3BLbCTfXTJ70mfYvKrplKwKBdm9M2TSTMnai9hM7 6hMtWSCPF7DIt8F35LeqRFBZrbIZfSMkMx4z7pgPunCJdN4YbSrqowEwmGUliMKmrVyz0u +rD0LBtaNWSd7rb3vvsgWScS/TsE6fg6dIpy1XAQSOeRhPfbLhHEPkPD4aUTQzHGxvDhnR 1ADy4IduqONAwUVO+tn5nRixaSb0p8HWDYOaxQJOOzaXsFCsvHezIBcdUPJOKQ19M5Tmc8 ElSdq9oBLKP2/TFb0npdaCKbGXWwnIBylJahnxcu9dRTKoyWNlLSYKZsiUFJMg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658668498; a=rsa-sha256; cv=none; b=Gz8o+dETN6vPrG933V9Hr8WKYfsAwua6BfXdXQO4T8wC4cx1zOS8shbo/H7W1gsJ6Ait9r bwR6GN9Sl1bNa4KeprebtJeVZQZR6lrLViktL4J6reuULF01VAQ4afi4bxKIjFNggOPw2/ 0ZfI4NfQF4vpMCpPAvlmWSj0r6CC8CTYAotMvn0H1XCvq7TrZA67zIKHUKTdbLgk8fVCTW GcK2o9usgczCzvWgZ1uO9MluyNNfhJyL/4cqVPNdZHdsi0J0G/KmliipzMILol5S5hkhfy c6chb1ZrHGg3WQZ9EjfeL0tasBGyFMMBQ7uu6El/5Fcbn9eOmmaq1nd+p8E4Ug== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oRd+69bb; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.23 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oRd+69bb; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 47AE220DD5 X-Spam-Score: -5.23 X-Migadu-Scanner: scn0.migadu.com X-TUID: PpxDw1KPXakj Max Nikulin writes: >>> It is `map-do' that causes the problem. Maybe earlier implementation in >>> Emacs-26 has some peculiarities. It is the version available from the >>> system repository for Ubuntu-20.04 LTS focal. >> >> Tests do not fail on my side using Emacs 26.3 > > Ihor, what is the origin of your Emacs-26.3? The patch uses `map-do' > with plist argument. I have tried: > > test-map-do.el > ---- >8 ---- > (require 'map) > (map-do (lambda (k v) (message "alist map-do: %S: %S" k v)) '((1 . 'a))) > (setq pl nil) > (setq pl (plist-put pl :a 'a)) > (message "plist: %S" pl) > (map-do (lambda (k v) (message "plist map-do %S: %S" k v)) pl) > ---- 8< ---- It also fails on my side. Yet, make test EMACS="emacs-26" does _not_ fail. I tried harder then and found that make test EMACS="emacs-26" BTEST_RE="test-ol/insert-link-insert-description" _does_ fail. > So I am puzzled how tests using a macro with map-do and plist may pass > under Emacs-26. I am also puzzled now. Running all the tests works, while running a single test does not. In any case, we cannot, unfortunately, use map-do here and should probably fall back to the previous version with cl-loop. Best, Ihor