From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57905: [PATCH] Fix eshell directory and executable completion on action t Date: Mon, 19 Sep 2022 10:22:34 +0200 Message-ID: <87v8pjwz79.fsf@gnus.org> References: <87a66x55hy.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4327"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57905@debbugs.gnu.org, Daniel Pettersson To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 19 11:07:01 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaCk1-0000vc-2e for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Sep 2022 11:07:01 +0200 Original-Received: from localhost ([::1]:54946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaCk0-0002jd-62 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Sep 2022 05:07:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaC3S-00010F-Q9 for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 04:23:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53207) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oaC3S-0001Of-HV for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 04:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oaC3S-0008K7-6Z for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 04:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Sep 2022 08:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57905 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57905-submit@debbugs.gnu.org id=B57905.166357576531951 (code B ref 57905); Mon, 19 Sep 2022 08:23:02 +0000 Original-Received: (at 57905) by debbugs.gnu.org; 19 Sep 2022 08:22:45 +0000 Original-Received: from localhost ([127.0.0.1]:52282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaC3B-0008JG-BV for submit@debbugs.gnu.org; Mon, 19 Sep 2022 04:22:45 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:47850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaC39-0008J1-Gl for 57905@debbugs.gnu.org; Mon, 19 Sep 2022 04:22:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8o6ptAm39kRwAf8vtT5CKKoC7nnNXuUf2hzppR/anHA=; b=aQ3vlbGjXcmFGgTwaJp1HDVh3p 4z0oleI5JdoQtGKGGEZucOIu6r0DZU7Gsk/mrjOI4IL7WittuTZu5GAN0WXsypfc69Fyp2hH75Am/ RhQ0kKTyHoQRtgvyyA+BMiX2iJmmsklIlJIKaBWGxKZ3Cajyp6aJ8xaq6/uMe//S/1g4=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaC31-0007Ap-3z; Mon, 19 Sep 2022 10:22:37 +0200 In-Reply-To: (Jim Porter's message of "Sun, 18 Sep 2022 17:31:01 -0700") X-Now-Playing: 13 & God's _Own Your Ghost_: "Death Major" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243058 Archived-At: Jim Porter writes: > That said, I wouldn't object to merging this without regression tests; > it doesn't seem fair to me to expect patch authors to write tests when > the component they're patching doesn't have tests in the first > place. :) Thanks. Daniel, I've now pushed your patch to Emacs 29. This change was just small enough to apply without assigning copyright to the FSF, but for future patches you want to submit, it might make sense to get the paperwork started now, so that subsequent patches can be applied speedily. Would you be willing to sign such paperwork?