From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#57639: [PATCH] Add new command 'toggle-theme' Date: Mon, 10 Oct 2022 04:17:38 +0300 Message-ID: <87v8os5vf1.fsf@protesilaos.com> References: <875yhzmz25.fsf@posteo.net> <87h715dnut.fsf@posteo.net> <87edw955ls.fsf@gnus.org> <8735coewsk.fsf@posteo.net> <871qs7ztgq.fsf@gnus.org> <87o7vbg56k.fsf@posteo.net> <874jx3ye41.fsf@gnus.org> <87bkrbfz8l.fsf@posteo.net> <871qs5lpo2.fsf@posteo.net> <87mtatagzv.fsf@gnus.org> <87edw5n2zm.fsf@posteo.net> <87o7v97zy2.fsf@gnus.org> <87bkr9newj.fsf@posteo.net> <871qs57yai.fsf@gnus.org> <87y1udlzlt.fsf@posteo.net> <87o7v953uf.fsf@gnus.org> <87tu50nca7.fsf@posteo.net> <87a6652lyb.fsf@posteo.net> <875ygtqdho.fsf@gnus.org> <87wn99114w.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12518"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 57639@debbugs.gnu.org To: Stefan Kangas , Philip Kaludercic , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 10 03:18:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohhQo-0002zi-R4 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Oct 2022 03:18:11 +0200 Original-Received: from localhost ([::1]:38492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohhQn-0003ar-A9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Oct 2022 21:18:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohhQg-0003ae-La for bug-gnu-emacs@gnu.org; Sun, 09 Oct 2022 21:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46063) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohhQg-0006Cq-DF for bug-gnu-emacs@gnu.org; Sun, 09 Oct 2022 21:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohhQg-0003wJ-2F for bug-gnu-emacs@gnu.org; Sun, 09 Oct 2022 21:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Oct 2022 01:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57639-submit@debbugs.gnu.org id=B57639.166536467115127 (code B ref 57639); Mon, 10 Oct 2022 01:18:02 +0000 Original-Received: (at 57639) by debbugs.gnu.org; 10 Oct 2022 01:17:51 +0000 Original-Received: from localhost ([127.0.0.1]:45141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohhQU-0003vu-Vo for submit@debbugs.gnu.org; Sun, 09 Oct 2022 21:17:51 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:33781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohhQT-0003vg-6t for 57639@debbugs.gnu.org; Sun, 09 Oct 2022 21:17:49 -0400 Original-Received: (Authenticated sender: public@protesilaos.com) by mail.gandi.net (Postfix) with ESMTPSA id AC764240002; Mon, 10 Oct 2022 01:17:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1665364663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6beP27oewjsOuLR2rD5TL8CIv3cTL8LHxxCMlO9H09Q=; b=bPjk0wZLY1xPn4O6luKJWATbKUGKZbCKazP17PVb2vSFn6oCyCc3rNi089HcmzzzXYktQ0 NyqAs8NnM2TplobCdbUffjV5ddEgKZd/btktW60cv7vyNwYWq2lL4z02ZWyobtehU/4nbz CjmtctHQZfZbmcTi+ACHYJMjGweYGlOepdXPAcIG55umm20yg6wklBc6oor1KOF1SkxZNO F9lJnMRLJf0tY6yEYA9ant9QH/JVk0mqCn+BQ5iEvm9xxnj53VSXaNVLqIYYA6+6v11e/A KuokXt/y3K7s8wv4Q4M+HDEbgEHvBsX0gLnPVRKk83VxuoJVrDxa5ugiNKVisA== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244980 Archived-At: > From: Stefan Kangas > Date: Sun, 9 Oct 2022 22:32:49 +0200 > > Philip Kaludercic writes: > >> --8<---------------cut here---------------start------------->8--- >> ;;;###autoload >> (when (and (boundp 'custom-theme-load-path) >> load-file-name) >> ;; Add theme folder to `custom-theme-load-path' when installing over MELPA. >> (add-to-list 'custom-theme-load-path >> (file-name-as-directory (file-name-directory load-file-name)))) >> --8<---------------cut here---------------end--------------->8--- >> >> from leuven-theme.el to be removed. > > Why would the above be necessary for leuven-theme.el in particular? > > I've never had a problem loading themes installed from MELPA, so I don't > understand why it should need any special treatment. Note that the modus-themes.el have this: ;;;###autoload (when load-file-name (let ((dir (file-name-directory load-file-name))) (unless (equal dir (expand-file-name "themes/" data-directory)) (add-to-list 'custom-theme-load-path dir)))) It is (was?) necessary to make the theme available when installing with package.el (GNU ELPA). -- Protesilaos Stavrou https://protesilaos.com